Editor overlay should have close icon on first screen
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The editor uses a back button (<-) to close the overlay.
This is inconsistent from the talk, categoryand the search overlay which use a close button (X)
The arrow icon should only show on overlay screens that close.

Decision

We will keep the X button for initial headers
We will use the back button for any immediate steps where clicking the icon will not close the overlay

Acceptance critera

When I click the edit icon the overlay has a close button in the top left and clicking it closes the overlay
When I click preview a back arrow icon shows in the top left and clicking it takes me back to the previous pane
On the save screen a close icon shows in the top left (as clicking it closes the overlay)

Details

Reference: bz71203

	Subject	Repo	Branch	Lines +/-
	Show correct icon in EditorOverlay	mediawiki/extensions/MobileFrontend	master	+2 -3

Customize query in gerrit

Related Objects

Mentioned In: T150105: Clicking back icon in edit view of mobile site should always display the article
T129955: Improve usability of Search bar on Mobile Web
T98518: oojs ui icon name conflict ('cancel') on overlay close buttons on mobile beta/alpha
T88631: Clear search button is missing on mobile search once you swith to full-text Search

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:50 AM

• bzimport added a project: Don't use – MobileFrontend-Hygiene.

• bzimport set Reference to bz71203.

Jdlrobson created this task.Sep 23 2014, 10:26 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/VdKb5Ris

gerritadmin wrote:

Change 162644 had a related patch set uploaded by Florianschmidtwelzow:
Use back button to leave Overlay on all Overlays

https://gerrit.wikimedia.org/r/162644

gerritadmin wrote:

Change 162644 abandoned by Florianschmidtwelzow:
Use back button to leave Overlay on all Overlays

Reason:
see Ie69635f8b2638354baefb4dda0421c1b9e823050

https://gerrit.wikimedia.org/r/162644

We need a designer to chip in before we consolidate this. It's not clear which is the right icon to use for close. It may be back but let's resolve this later.

Jdforrester-WMF edited projects, added Technical-Debt, MobileFrontend-General-or-Unknown; removed Don't use – MobileFrontend-Hygiene.Dec 8 2014, 9:42 PM

Jdlrobson edited projects, added Web-Team-Backlog, Wikimedia-Design; removed MobileFrontend-General-or-Unknown.Dec 9 2014, 11:39 PM

Jdlrobson set Security to None.

Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Dec 10 2014, 12:14 AM

Florian mentioned this in T88631: Clear search button is missing on mobile search once you swith to full-text Search.Feb 5 2015, 5:09 PM

The description leads me to believe that Kaity favors using the back arrow when content creation/editing is involved. Currently that is the case for the editing interface and both the interfaces for adding content to talk. The search and initial talk interfaces don't involve content creation/editing, so the 'x' is appropriate.

I suggest closing as invalid.

Any thoughts on this @MSyed @KHammerstein?

Jdlrobson moved this task from Upcoming to 2015-16 Q4 on the Web-Team-Backlog board.Mar 9 2015, 1:02 PM

Jdlrobson moved this task from 2015-16 Q4 to 2016-17 Q2 on the Web-Team-Backlog board.

• KLans_WMF moved this task from 2016-17 Q2 to Incoming on the Web-Team-Backlog board.Apr 8 2015, 10:41 PM

Jdlrobson moved this task from Incoming to 2017-18 Q3 on the Web-Team-Backlog board.Apr 10 2015, 5:06 PM

Jdlrobson moved this task from 2017-18 Q3 to Upcoming on the Web-Team-Backlog board.

Jdlrobson mentioned this in T98518: oojs ui icon name conflict ('cancel') on overlay close buttons on mobile beta/alpha.May 8 2015, 10:09 PM

Since Design hasn't still responded, I suggest we keep the X button for the initial header and keep using the back button for the following steps in the edit process. If I'm not mistaken, all other overlays use X for closing the overlay.

• Jhernandez triaged this task as Low priority.Aug 18 2015, 5:16 PM

• Jhernandez edited projects, added MobileFrontend, Design; removed Web-Team-Backlog.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2015, 5:16 PM

Krenair subscribed.Sep 9 2015, 2:56 AM

Jdlrobson moved this task from Backlog to Discussing on the MobileFrontend board.Nov 4 2015, 5:29 PM

Jdlrobson mentioned this in T129955: Improve usability of Search bar on Mobile Web.May 10 2016, 4:05 PM

Since Design hasn't still responded, I suggest we keep the X button for the initial header and keep using the back button for the following steps in the edit process. If I'm not mistaken, all other overlays use X for closing the overlay.

Agreed. the first step should have cross and following steps should have back.

MBinder_WMF added a project: Web-Team-Backlog.May 17 2016, 6:32 PM

MaxSem unsubscribed.May 17 2016, 6:38 PM

Jdlrobson moved this task from Upcoming to 2016-17 Q1 on the Web-Team-Backlog board.May 18 2016, 3:13 PM

Jdlrobson moved this task from 2016-17 Q1 to Incoming on the Web-Team-Backlog board.May 18 2016, 3:35 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Jun 1 2016, 4:44 PM

• Nirzar moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Jul 28 2016, 5:31 PM

MBinder_WMF added a project: Reading-Web-Tech-Debt.Oct 3 2016, 8:35 PM

MBinder_WMF edited projects, added Technical-Debt (RW-Tech-Debt); removed Technical-Debt.Oct 4 2016, 6:16 PM

MBinder_WMF removed a project: Reading-Web-Tech-Debt.Oct 4 2016, 7:54 PM

• bmansurov moved this task from Uncategorized to Improvements on the Technical-Debt (RW-Tech-Debt) board.Oct 7 2016, 5:35 PM

Aklapper added a project: UI-Standardization.Oct 10 2016, 7:35 PM

Jdlrobson mentioned this in T150105: Clicking back icon in edit view of mobile site should always display the article.Nov 10 2016, 10:25 AM

Volker_E moved this task from Unsorted to Color consistency on the UI-Standardization board.Dec 11 2016, 7:17 PM

Volker_E moved this task from Color consistency to Icons standardization on the UI-Standardization board.

Volker_E moved this task from Incoming to WMF Design Offsite 2017-01 on the Design board.Jan 5 2017, 7:31 PM

Volker_E removed subscribers: • MSyed, • Tfinc, • KHammerstein.Jan 5 2017, 10:20 PM

Volker_E moved this task from Incoming to WMF UI Std Offsite 2017-01 on the Wikimedia-Design board.Jan 5 2017, 10:32 PM

Volker_E moved this task from WMF Design Offsite 2017-01 to Triaged on the Design board.Jan 5 2017, 10:35 PM

Not clear what to do here so not triaged but future.

Actually looks like we can work on this. Let me update description per https://phabricator.wikimedia.org/T73203#2283614

Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.Jun 23 2017, 8:47 PM

Jdlrobson renamed this task from Inconsistency: Editor uses back icon for closing overlay, talk uses X to Editor overlay should have close icon on first screen.Jun 23 2017, 9:26 PM

Jdlrobson raised the priority of this task from Low to Medium.

Jdlrobson edited projects, added Design (RW-Design-Debt), good first task; removed Design.

Jdlrobson updated the task description. (Show Details)

Restricted Application edited projects, added Design; removed Design (RW-Design-Debt). · View Herald TranscriptJun 23 2017, 9:26 PM

Restricted Application added a subscriber: TerraCodes. · View Herald Transcript

Jdlrobson moved this task from Needs Prioritization to Upcoming on the Web-Team-Backlog board.Jun 23 2017, 9:26 PM

Jdlrobson set the point value for this task to 2.Jun 27 2017, 4:58 PM

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.Jun 27 2017, 5:04 PM

Jdlrobson moved this task from Upcoming to 2016-17 Q4 on the Web-Team-Backlog board.Jun 27 2017, 5:24 PM

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jun 28 2017, 5:20 PM

Jdlrobson removed Jdlrobson as the assignee of this task.Jul 3 2017, 4:19 PM

• bmansurov claimed this task.Jul 6 2017, 9:15 PM

• bmansurov moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.

Change 363732 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/extensions/MobileFrontend@master] Show correct icon in EditorOverlay

https://gerrit.wikimedia.org/r/363732

gerritbot added a project: Patch-For-Review.Jul 6 2017, 9:36 PM

• bmansurov moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jul 6 2017, 9:37 PM

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jul 6 2017, 11:00 PM

• bmansurov removed • bmansurov as the assignee of this task.Jul 6 2017, 11:04 PM

Change 363732 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Show correct icon in EditorOverlay

https://gerrit.wikimedia.org/r/363732