This loks like a clear icon:
So does this:
Should look like:
Description
Description
Should look like:
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix oojs ui icon naming conflict | mediawiki/extensions/MobileFrontend | master | +15 -18 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web | |||
| Open | None | T54165 Links to talk pages in mobile view for all anonymous users | |||
| Resolved | • bmansurov | T98518 oojs ui icon name conflict ('cancel') on overlay close buttons on mobile beta/alpha |
Event Timeline
Comment Actions
Arrrrh, this is a regression from T97804, I didn't realize you guys have a 'cancel' icon. I think that in this case it's MobileFrontend having bad naming. This is a 'close', not a 'cancel': 
OOjs UI's 'close' icon looks like this: 
(this is the same size as the icon above, it's a lot lighter).
Comment Actions
Bad naming or not we really need to be careful from now on. Our icons in mobile have been stable for some time and have been around for over a year prior to this.
In mobile we annoyingly have close and cancel icons due to this: T73203 @KHammerstein now would be good time to make a final decision on whether we want to replace this icon with a back <- icon or close X icon for our overlays
Comment Actions
@Florian the icon needs to be swapped out for 'close' The 'cancel' class still needs to be present though for the overlay to be compatible with the routing.
e.g.
class="mw-ui-icon mw-ui-icon-close mw-ui-icon-element cancel"
Comment Actions
Change 215953 had a related patch set uploaded (by Bmansurov):
Fix oojs ui icon naming conflict