Page MenuHomePhabricator

oojs ui icon name conflict ('cancel') on overlay close buttons on mobile beta/alpha
Closed, ResolvedPublic

Description

This loks like a clear icon:

not a close icon.

So does this:


Should look like:

Event Timeline

Jdlrobson created this task.May 7 2015, 7:54 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task to Incoming on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2015, 7:54 PM
phuedx added a subscriber: phuedx.

Yay! UI regressions!

Arrrrh, this is a regression from T97804, I didn't realize you guys have a 'cancel' icon. I think that in this case it's MobileFrontend having bad naming. This is a 'close', not a 'cancel':

OOjs UI's 'close' icon looks like this: (this is the same size as the icon above, it's a lot lighter).

matmarex renamed this task from oojs ui buttons interfering with overlay close buttons on mobile beta/alpha to oojs ui icon name conflict ('cancel') on overlay close buttons on mobile beta/alpha.May 8 2015, 10:03 PM
matmarex set Security to None.

Bad naming or not we really need to be careful from now on. Our icons in mobile have been stable for some time and have been around for over a year prior to this.

In mobile we annoyingly have close and cancel icons due to this: T73203 @KHammerstein now would be good time to make a final decision on whether we want to replace this icon with a back <- icon or close X icon for our overlays

Can we have some input here to resolve it? :)

@Florian the icon needs to be swapped out for 'close' The 'cancel' class still needs to be present though for the overlay to be compatible with the routing.

e.g.
class="mw-ui-icon mw-ui-icon-close mw-ui-icon-element cancel"

bmansurov claimed this task.Jun 4 2015, 6:13 PM
bmansurov moved this task from To Do to Doing on the Mobile-Web-Sprint-48-Voyage-of-the-Damned board.

Change 215953 had a related patch set uploaded (by Bmansurov):
Fix oojs ui icon naming conflict

https://gerrit.wikimedia.org/r/215953

Change 215953 merged by jenkins-bot:
Fix oojs ui icon naming conflict

https://gerrit.wikimedia.org/r/215953

@Jdlrobson @Florian Do we have the ability to change the color of the oo-ui icons?

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Jun 10 2015, 2:28 AM
Danny_B moved this task from Unsorted to OOUI on the UI-Standardization board.May 20 2016, 8:58 PM