Inconsistent icon used in mobile/oojs ui for clearing search results.
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	May 1 2015, 5:19 PM

Description

Firstly which one of these is correct?

Secondly:

if oojsui is incorrect icon then a new svg asset is required.
if mobile web is incorrect icon we need to update these in mobile we should copy across the svgs used by oojs ui for this icon this will make switching to oojs ui in future seamless.

Screen_Shot_2015-05-01_at_10.17.22_AM.png (190×629 px, 27 KB)

Screen_Shot_2015-05-01_at_10.17.01_AM.png (231×392 px, 16 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Update icon name: clear → cancel after Idbd0da9f in OOjs UI	VisualEditor/VisualEditor	master	+2 -2
	Rename icons: clear → cancel, closeInput → clear	oojs/ui	master	+10 -14

Customize query in gerrit

Related Objects

Mentioned In: T98518: oojs ui icon name conflict ('cancel') on overlay close buttons on mobile beta/alpha
rGVED8b623ce74eb6: Update icon name: clear → cancel after Idbd0da9f in OOjs UI
rGOJUfc0f43988b72: Rename icons: clear → cancel, closeInput → clear
T97793: Audit icon names in OOjs UI and MobileFrontend for conflicts

Event Timeline

Jdlrobson created this task.May 1 2015, 5:19 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: Web-Team-Backlog, UI-Standardization, OOUI.

Jdlrobson moved this task to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson added subscribers: Jdlrobson, matmarex.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2015, 5:19 PM

Jdlrobson mentioned this in T97793: Audit icon names in OOjs UI and MobileFrontend for conflicts.May 1 2015, 5:23 PM

I think it should be possible to use MobileFrontend's icon in OOjs UI. We use it in two places in VE:

matmarex claimed this task.May 1 2015, 5:53 PM

Oh, we have this icon available in OOjs UI as closeInput: . I think it'll be simplest to just use that in MF.

But it's not really a "close", wouldn't it be better to use the OOJsUI clear icon? :)

matmarex claimed this task.May 2 2015, 9:24 PM

Change 208467 had a related patch set uploaded (by Bartosz Dziewoński):
Rename icons: clear → cancel, closeInput → clear

https://gerrit.wikimedia.org/r/208467

gerritbot added a project: Patch-For-Review.May 2 2015, 9:34 PM

Indeed. If the above is merged, you shouldn't need any changes in MobileFrontend.

Change 208468 had a related patch set uploaded (by Bartosz Dziewoński):
Update icon name: clear → cancel after Idbd0da9f in OOjs UI

https://gerrit.wikimedia.org/r/208468

Jdforrester-WMF triaged this task as Low priority.May 4 2015, 6:05 PM

Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.

Jdforrester-WMF closed this task as Resolved.May 4 2015, 6:26 PM

Jdforrester-WMF edited projects, added OOjs-UI-next-release, VisualEditor 2014/15 Q4 blockers; removed Patch-For-Review.

Jdforrester-WMF set Security to None.

Change 208467 merged by jenkins-bot:
Rename icons: clear → cancel, closeInput → clear

https://gerrit.wikimedia.org/r/208467

matmarex mentioned this in rGOJUfc0f43988b72: Rename icons: clear → cancel, closeInput → clear.May 4 2015, 6:31 PM

Change 208468 merged by jenkins-bot:
Update icon name: clear → cancel after Idbd0da9f in OOjs UI

https://gerrit.wikimedia.org/r/208468

matmarex mentioned this in rGVED8b623ce74eb6: Update icon name: clear → cancel after Idbd0da9f in OOjs UI.May 5 2015, 1:48 AM

Jdforrester-WMF edited a custom field.May 5 2015, 3:55 PM

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.11.1), WMF-deploy-2015-05-06_(1.26wmf5); removed OOjs-UI-next-release.May 5 2015, 11:29 PM

Jdforrester-WMF moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.May 6 2015, 12:58 AM

matmarex mentioned this in T98518: oojs ui icon name conflict ('cancel') on overlay close buttons on mobile beta/alpha.May 8 2015, 10:02 PM

Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.May 31 2015, 11:01 PM

Danny_B moved this task from Unsorted to OOUI on the UI-Standardization board.May 20 2016, 8:59 PM

• Phabricator_maintenance moved this task from Triaged but Future to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:32 AM

Restricted Application edited projects, added User-Ryasmeen; removed OOUI (OOjs-UI-0.11.1). · View Herald TranscriptMar 7 2018, 1:32 AM

	F159356: Screen_Shot_2015-05-01_at_10.17.01_AM.png
	May 1 2015, 5:19 PM

	F159355: Screen_Shot_2015-05-01_at_10.17.22_AM.png
	May 1 2015, 5:19 PM

	F159372: closeInput.png
	May 1 2015, 5:57 PM

	F159365: pasted_file
	May 1 2015, 5:36 PM

	F159363: pasted_file
	May 1 2015, 5:36 PM

Inconsistent icon used in mobile/oojs ui for clearing search results.Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Inconsistent icon used in mobile/oojs ui for clearing search results.
Closed, ResolvedPublic1 Estimated Story Points
Actions