Page MenuHomePhabricator

Audit icon names in OOjs UI and MobileFrontend for conflicts
Closed, ResolvedPublic

Description

Audit icon names in OOjs UI and MobileFrontend for conflicts.

After T92551, OOjs UI icons names are available as .mw-ui-icon-foo in MediaWiki core. This turned out to conflict with existing icons in MobileFrontend and friends (T97473, T97654). Let's make a list and check it twice.

Event Timeline

matmarex created this task.May 1 2015, 4:52 PM
matmarex updated the task description. (Show Details)
matmarex raised the priority of this task from to Unbreak Now!.
matmarex claimed this task.
matmarex added a subscriber: matmarex.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2015, 4:52 PM

List of icons in OOjs UI:

add
advanced
alert
check
circle
clear
close
code
collapse
comment
ellipsis
expand
help
history
info
menu
next
picture
previous
redo
remove
search
settings
tag
undo
window
arrowLast
arrowNext
downTriangle
upTriangle
caretLast
caretNext
caretDown
caretUp
move
article
articleCheck
articleSearch
citeArticle
book
journal
newspaper
folderPlaceholder
die
download
upload
bell
bellOn
eye
eyeClosed
message
signature
speechBubble
speechBubbleAdd
speechBubbles
beta
betaLaunch
bookmark
browser
clock
closeInput
funnel
heart
key
keyboard
logOut
magnifyingGlass
newWindow
printer
ribbonPrize
sun
watchlist
block
blockUndo
flag
flagUndo
lock
star
trash
trashUndo
unStar
unLock
edit
editLock
editUndo
link
linkExternal
linkSecure
bigger
smaller
subscript
superscript
bold
italic
strikethrough
underline
textLanguage
textDirLTR
textDirRTL
textStyle
indent
listBullet
listNumbered
outdent
alignCentre
alignLeft
alignRight
find
insert
layout
newline
noWikiText
outline
puzzle
quotes
quotesAdd
redirect
searchCaseSensitive
searchRegularExpression
specialCharacter
table
tableAddColumnAfter
tableAddColumnBefore
tableAddRowAfter
tableAddRowBefore
tableCaption
tableMergeCells
templateAdd
translation
wikiText
image
imageAdd
imageLock
photoGallery
play
stop
map
mapPin
mapPinAdd
wikitrail
userActive
userAvatar
userInactive
userTalk
stripeFlow
stripeSideMenu
stripeSummary
stripeToC
viewCompact
viewDetails
visionSimulator
logoCC
logoWikimediaCommons
logoWikipedia

MediaWiki UI icons

MediaWiki core:
ok
MobileFrontend, defined via ResourceLoaderImageModule:
notifications
mainmenu
search
search-white
arrow-down
arrow-up
talk
watch
watched
edit
edit-enabled
addimage
addimage-enabled
edit-source
edit-ve
edit-switch
toc
cleanup
cleanup-gray
user
anonymous
citation
cancel-light
watch
watched
edit
edit-enabled
back-mobilemenu
MobileFrontend, defined in /less/iconsNew.less:
home
refresh
random
watchlist
uploads
nearby
settings
mobileoptions
secondary-logout
profile
anonymous-white
cancel
clear
photo
previous
next
bytesadded
bytesremoved
bytesneutral
back
spinner
Gather, defined via ResourceLoaderImageModule:
collections-icon
collections-read-more
collection-owner
collection-flag
collection-hide
tick-disabled
tick

And so, the conflicting ones are:

search
edit
watchlist
settings
clear
previous
next
phuedx moved this task from 2014-15 Q4 to 2015-16 Q4 on the Readers-Web-Backlog board.

Thanks for doing this Bartosz!
compatible:

  • search: used in UI (covered)
  • settings: used in left menu (covered)

Compatible but different icon used:

  • clear: used in search to clear results (png only)

Broken:

  • next: used in alpha image overlay to pan left or right from images [1]
  • previous: used in alpha image overlay to pan left or right from images [1] Can be fixed by using 'next-invert' but seems tiny

Compatibility unknown:

  • watchlist: used in left menu (png in mobile but doesn't seem to be loaded in icon pack on mobile so not overriding)
  • edit: used in edit icon (png in mobile)

If we could review the compatibility unknown ones I think we can close this bug. I'm setting up new bugs for the next/previous and clear icons.

[1] http://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?mobileaction=alpha#/media/File:Einstein_Albert_Elsa_LOC_32096u.jpg

iconOOjs UIMobileFrontend
search
edit
watchlist (white icon)
settings (white icon)
clear
previous
next

Looks like we need to standardise on a watchlist icon too then :)
I think using the new icon for previous and next should be uncontroversial.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMar 7 2018, 1:20 AM