Page MenuHomePhabricator
Create Task
Maniphest T97473

oojs ui settings icon and MobileFrontend main menu settings icon are clashing
Closed, ResolvedPublic
Actions

Description

Screen_Shot_2015-04-28_at_2.11.42_PM.png (434×237 px, 22 KB)

oh nooos in beta when you visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?mobileaction=beta and click hamburger
The setting icon should be a cog not this.

It seems oojs-ui.styles.icons clashes with the css rule defined by mobile and trumps it due to being loaded after.

Details

SubjectRepoBranchLines +/-
Fix settings icon in betamediawiki/extensions/MobileFrontendmaster+4 -2
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Apr 28 2015, 9:11 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson moved this task to Incoming on the Web-Team-Backlog board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2015, 9:11 PM
Jdlrobson added a comment.Apr 28 2015, 10:07 PM

Looks like this is from VisualEditor http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?modules=oojs-ui.styles.icons
We should probably both use more specific icons.
http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?modules=oojs-ui.styles.icons&only=styles&debug=true

Jdlrobson renamed this task from Unsoliciated settings icon to oojs ui settings icon and MobileFrontend main menu settings icon are clashing.Apr 28 2015, 10:07 PM
Jdlrobson set Security to None.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: OOUI.
Jdlrobson added subscribers: Esanders, Jdforrester-WMF.
matmarex subscribed.Apr 28 2015, 10:11 PM
Jdlrobson updated the task description. (Show Details)Apr 28 2015, 10:12 PM
gerritbot subscribed.Apr 28 2015, 10:22 PM

Change 207294 had a related patch set uploaded (by Jdlrobson):
Fix settings icon in beta

https://gerrit.wikimedia.org/r/207294

gerritbot added a project: Patch-For-Review.Apr 28 2015, 10:22 PM
Jdlrobson claimed this task.Apr 28 2015, 10:23 PM
Jdlrobson added a project: Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story.
Jdlrobson moved this task from Needs Analysis to Code Review on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.
Jdlrobson moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.
gerritbot added a comment.Apr 28 2015, 11:36 PM

Change 207294 merged by jenkins-bot:
Fix settings icon in beta

https://gerrit.wikimedia.org/r/207294

Diffusion mentioned this in rMEXT41cbf9462ec3: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Apr 28 2015, 11:36 PM
Jdlrobson mentioned this in rEMFR60446b108e62: Fix settings icon in beta.Apr 28 2015, 11:36 PM
matmarex edited projects, added MediaWiki-General; removed OOUI.Apr 29 2015, 12:30 PM
• bmansurov closed this task as Resolved.Apr 29 2015, 8:06 PM
• bmansurov moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.
• bmansurov subscribed.
phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.Apr 30 2015, 8:45 AM
phuedx removed a project: Patch-For-Review.
matmarex mentioned this in T97793: Audit icon names in OOjs UI and MobileFrontend for conflicts.May 1 2015, 4:52 PM
matmarex added a comment.May 1 2015, 5:06 PM

I filed T97793 to track down the conflicts.

• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits