Page MenuHomePhabricator

Clicking back icon in edit view of mobile site should always display the article
Closed, DeclinedPublic

Description

When an user attempts to click Back icon in edit view after logging in( using the link in the edit view that would be displayed when he tries to edit without logging in) it repeatedly shows the edit window instead of displaying the article. Sometimes it also seems to display the login page. In no case (if the user follows the below steps) does it show the article in Reading view. This seems to be the case with all Wikimedia sites.

Pre-conditions : You must be logged out of Wikipedia before following the below steps. All steps below are to be done using a mobile browser.

Steps to reproduce

  1. Go to the Robert Catesby article (or any other article you like to edit)
  2. Click the Edit icon (Warning message for not logging in should be displayed)
  3. Log in to Wikipedia using the Log in link in the page (After successful login, you would be redirected back to edit view of article)
  4. Click back icon found at the top near the title Editing Robert..

Expected result
Edit view is exited and article is displayed

Actual result
Edit view is displayed or sometimes Login page is displayed

It's like a infinite loop and would not allow the user to exit the edit view.

Event Timeline

Kaartic updated the task description. (Show Details)
ovasileva added a project: Web-Team-Backlog.
ovasileva lowered the priority of this task from High to Medium.Nov 9 2016, 5:27 PM

This has been a longstanding issue and the subject of other bugs (not sure if @kaldari remembers the fate of those). It's tricky to solve.

@Nirzar should the first close icon inside the editor overlay be the X button similar to the language overlay and subsequent icons are a left arrow?

@bmansurov: T73203

@ovasileva In triage, I suggested this might need a spike, but having revisiting it this morning, I just realised that this particular issue is a lot simpler than the more generic issue of sharing edit link and quite trivially fixed if we want to. This could easily be solved by using replaceState or strengthening the if statement to only run once:

The offending code is in resources/skins.minerva.newusers/init.js
[ignore this is incorrect]

https://en.m.wikipedia.org/w/index.php?title=Millipede&section=0&action=edit causes a redirect to Special:MobileEditor
We'd need to look at that logic. I'd suggest if we do work on this we scope it to a certain number of hours as it may be trickier than we might expect.

It's annoying, but hopefully will go away as soon as T125174 is resolved.

@Jdlrobson: Normally I'm a fan of your ruthless triaging, but this seems like a legit bug.

T125174 will resolve it. The issue is with Special:MobileEditor which will be removed with T125174. We can stall it and then revisit it then, but i'd worry I'd forget to do that :)

We can stall it and then revisit it then, but i'd worry I'd forget to do that :)

If you don't mind, I could help you with that :)