Page MenuHomePhabricator
Create Task
Maniphest T88655

Phabricator should treat comment inputs containing only whitespace characters as empty when deciding whether the user made a comment or not
Closed, ResolvedPublic
Actions

Description

If you change a task's status, for example, and accidentally type " " in the comment field, you will see a blank line in the history view.

Trim leading and trailing whitespace, before applying emptiness test on the comment value.

Related Objects

Event Timeline

awight created this task.Feb 5 2015, 7:05 AM
awight raised the priority of this task from to Low.
awight updated the task description. (Show Details)
awight added a project: Phabricator.
awight subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2015, 7:05 AM
Qgil lowered the priority of this task from Low to Lowest.Feb 5 2015, 7:50 AM
Qgil edited projects, added Phabricator (Upstream); removed Phabricator.
Qgil set Security to None.
Qgil moved this task from Backlog to Ready To Go on the Phabricator (Upstream) board.Feb 5 2015, 9:23 AM
Krenair updated the task description. (Show Details)May 14 2015, 7:09 PM
scfc added subscribers: scfc, Krenair.Feb 5 2016, 3:06 AM
scfc added a comment.Feb 5 2016, 3:08 AM
scfc added a comment.Feb 5 2016, 3:08 AM

Just wanted to test how this bug manifests itself (see above) and if it's different from @Krenair's T125834 (it is; T125802#1998113 looks different).

Krenair added a comment.Feb 5 2016, 3:50 AM
In T88655#2000992, @scfc wrote:

Just wanted to test how this bug manifests itself (see above) and if it's different from @Krenair's T125834 (it is; T125802#1998113 looks different).

That bug is about input via email, not via the web interface.

Danny_B added a project: Upstream.May 23 2016, 6:03 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 23 2016, 6:03 PM
awight unsubscribed.Mar 21 2019, 4:07 PM
epriestley mentioned this in T125834: Emails about users adding blank comments via email which don't show in the web UI.May 30 2019, 7:36 PM
epriestley moved this task from Ready To Go to Solved upstream on the Phabricator (Upstream) board.May 30 2019, 7:39 PM
epriestley subscribed.

This should be resolved upstream by https://secure.phabricator.com/D20562.

I'm going to tweak the title here to align it slightly better to the desired/implemented behavior: it's intentional that we don't trim leading and trailing whitespace out of the input entirely because <space><space>xyz is a valid comment starting with a piece of codeblock-formatted text.

epriestley renamed this task from Phabricator comment input should trim whitespace to Phabricator should treat comment inputs containing only whitespace characters as empty when deciding whether the user made a comment or not.May 30 2019, 7:39 PM
Aklapper closed this task as Resolved.Jul 4 2019, 1:50 AM
Aklapper edited projects, added Phabricator (2019-07-03); removed Phabricator (Upstream).

Closing as per last comment as a more recent software version is now deployed on phabricator.wikimedia.org.
If this is still a problem, then please set the status of this report back to "Open" via the Add Action... → Change Status dropdown. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL