Page MenuHomePhabricator

Phabricator should treat comment inputs containing only whitespace characters as empty when deciding whether the user made a comment or not
Closed, ResolvedPublic

Description

If you change a task's status, for example, and accidentally type " " in the comment field, you will see a blank line in the history view.

Trim leading and trailing whitespace, before applying emptiness test on the comment value.

Event Timeline

awight raised the priority of this task from to Low.
awight updated the task description. (Show Details)
awight added a project: Phabricator.
awight added a subscriber: awight.
Qgil lowered the priority of this task from Low to Lowest.Feb 5 2015, 7:50 AM
Qgil edited projects, added Phabricator (Upstream); removed Phabricator.
Qgil set Security to None.

Just wanted to test how this bug manifests itself (see above) and if it's different from @Krenair's T125834 (it is; T125802#1998113 looks different).

Just wanted to test how this bug manifests itself (see above) and if it's different from @Krenair's T125834 (it is; T125802#1998113 looks different).

That bug is about input via email, not via the web interface.

epriestley added a subscriber: epriestley.

This should be resolved upstream by https://secure.phabricator.com/D20562.

I'm going to tweak the title here to align it slightly better to the desired/implemented behavior: it's intentional that we don't trim leading and trailing whitespace out of the input entirely because <space><space>xyz is a valid comment starting with a piece of codeblock-formatted text.

epriestley renamed this task from Phabricator comment input should trim whitespace to Phabricator should treat comment inputs containing only whitespace characters as empty when deciding whether the user made a comment or not.May 30 2019, 7:39 PM

Closing as per last comment as a more recent software version is now deployed on phabricator.wikimedia.org.
If this is still a problem, then please set the status of this report back to "Open" via the Add Action...Change Status dropdown. Thanks!