Page MenuHomePhabricator

Parsoid Cite: Render missing reflists
Closed, ResolvedPublic0 Estimated Story Points

Description

Since https://gerrit.wikimedia.org/r/#/c/141583/, Cite.php renders missing reflists (that is, left over refs that haven't been rendered in a references group yet) at the bottom of the page. Parsoid's Cite extensions should do the same.

Event Timeline

marcoil raised the priority of this task from to Needs Triage.
marcoil updated the task description. (Show Details)
marcoil added a project: Parsoid.
marcoil subscribed.
ssastry set Security to None.
ssastry moved this task from Needs Triage to VE Q3 on the Parsoid board.
gerritbot subscribed.

Change 189974 had a related patch set uploaded (by Marcoil):
WIP: T88660: Emit reflists for <ref> with no explicit <references>

https://gerrit.wikimedia.org/r/189974

Patch-For-Review

The WIP in progress patch adds references lists for all <ref> groups that have <ref>s which haven't been output yet. This is different from the current Cite.php's behavior of only outputting orphan <ref>s in the default group, but may be necessary to make T88290 work.

Another issue is that when sending the resulting HTML back to Parsoid for html2wt, the missing <reference>s are included. This may be an acceptable dirty diff as it fixes a problem in the page. Opinions?

I think it is acceptable. In any case, selser will handle the unedited refs scenario.

Change 189974 merged by jenkins-bot:
T88660: Emit reflists for <ref> with no explicit <references>

https://gerrit.wikimedia.org/r/189974