Add support to run selser tests with custom edits on original wikitext
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ssastry
	Sep 11 2014, 3:19 PM

Description

parserTests.js currently supports "changes" on the DOM generated by parsing input wikitext. That "changes" support should also include a "remove" option to delete a DOM element. In addition, we should be able to now serialize the edited DOM via selser. Given that "selser" is currently a mode that generates automated edits, we probaly need a "manual_selser" (or some such named mode) to apply selser on an edited DOM.

This would be helpful to force explicit testing of selser behavior that would be useful for patches like https://gerrit.wikimedia.org/r/#/c/157038/ with examples as in https://gist.githubusercontent.com/subbuss/5f0872ce4c20bed622bc/raw/d4720f260f4a3131e3963f012ec289eaf37a202c/gistfile1.txt (and others).

Version: unspecified
Severity: normal

Details

Reference: bz70722

	Subject	Repo	Branch	Lines +/-
	Add $().remove and $().empty methods to parser test manual changes.	mediawiki/services/parsoid	master	+15 -0

Customize query in gerrit

Related Objects

Mentioned In: rGPAR54de4d8e198f: [parserTests] T72722: Support manual changes in selser tests
rGPAR96dd987d5071: T90517: Reinstate modification markers for comments
rGPAR7608aeabdc1e: Deal with chameleon nodes that change output based on surroundings
rGPAR91cd00f5405c: T90517: Update node modification flags in the main loop of WTS.
rGPAR26e2898fc919: T89383: Check for validity of DSR before fetching wikitext for it
rGPARc3226a6e72ca: Bug fix in heading wikitext escape handler
rGPAR56b0ab26377b: Fix quote minimization to deal with edits more comprehensively
rGPAR5fd911abd92d: Add $().remove and $().empty methods to parser test manual changes.
Mentioned Here: T88660: Parsoid Cite: Render missing reflists

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:53 AM

• bzimport added a project: Parsoid-Tests.

• bzimport set Reference to bz70722.

• ssastry created this task.Sep 11 2014, 3:19 PM

Arlolra added a project: Parsoid.Nov 25 2014, 6:56 PM

Arlolra set Security to None.

Till this support is in place, I cannot add tests for fixes in https://gerrit.wikimedia.org/r/#/c/177761/

So, before resolving this task, tests should be added for the patches listed in this task.

Change 179481 had a related patch set uploaded (by Cscott):
Add $().remove and $().empty methods to parser test manual changes.

https://gerrit.wikimedia.org/r/179481

Patch-For-Review

The above patch fixes the "changes" support in parser tests, but it doesn't address the "manual_selser" part of the task.

Change 179481 merged by jenkins-bot:
Add $().remove and $().empty methods to parser test manual changes.

https://gerrit.wikimedia.org/r/179481

• ssastry moved this task from Needs Triage to Testing on the Parsoid board.Dec 20 2014, 4:13 AM

• marcoil moved this task from Testing to Needs Triage on the Parsoid board.Feb 13 2015, 12:50 PM

Once this is fixed, we should revisit the test "References: 9." to create some manual changes and ensure that new <references /> are not created for changes unrelated to orphan <ref>s. See T88660.

https://gerrit.wikimedia.org/r/#/c/190595/ is another patch that benefits from this support.

• ssastry moved this task from Needs Triage to VE Q3 on the Parsoid board.Mar 3 2015, 3:15 PM

There are 3 more recent patches of mine that would benefit from this support. So, I moved it to the VE Q3 board.

• ssastry removed a project: Patch-For-Review.Mar 3 2015, 4:35 PM

• marcoil claimed this task.Mar 5 2015, 5:54 PM

Change 194912 had a related patch set uploaded (by Marcoil):
[parserTests] T72722: Support manual changes in selser tests

https://gerrit.wikimedia.org/r/194912

gerritbot added a project: Patch-For-Review.Mar 6 2015, 6:22 PM

Change 194912 merged by jenkins-bot:
[parserTests] T72722: Support manual changes in selser tests

https://gerrit.wikimedia.org/r/194912

With https://gerrit.wikimedia.org/r/#/c/197422/ in place, this task is considered done. Now to go add some deterministic selser tests for things we want to guarantee testing always ...

cscott mentioned this in rGPAR5fd911abd92d: Add $().remove and $().empty methods to parser test manual changes..Apr 8 2015, 4:28 PM

• ssastry mentioned this in rGPAR56b0ab26377b: Fix quote minimization to deal with edits more comprehensively.Apr 8 2015, 4:28 PM

cscott mentioned this in rGPARc3226a6e72ca: Bug fix in heading wikitext escape handler.Apr 8 2015, 4:28 PM

• ssastry mentioned this in rGPAR26e2898fc919: T89383: Check for validity of DSR before fetching wikitext for it.Apr 8 2015, 4:28 PM

• marcoil mentioned this in rGPAR7608aeabdc1e: Deal with chameleon nodes that change output based on surroundings.Apr 8 2015, 4:28 PM

• ssastry mentioned this in rGPAR91cd00f5405c: T90517: Update node modification flags in the main loop of WTS..Apr 8 2015, 4:28 PM

• ssastry mentioned this in rGPAR96dd987d5071: T90517: Reinstate modification markers for comments.

• marcoil mentioned this in rGPAR54de4d8e198f: [parserTests] T72722: Support manual changes in selser tests.Apr 8 2015, 4:28 PM