Fatal error causing phpunit tests to fail
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Jsahleen
	Feb 11 2015, 5:10 PM

Description

PHPUnit tests are failing with the following error for this patch: https://gerrit.wikimedia.org/r/#/c/177987/

15:59:14 Fatal error: Class Mock_BagOStuff_dbf9b0e9 contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (BagOStuff::cas) in /srv/deployment/integration/phpunit/vendor/phpunit/phpunit-mock-objects/PHPUnit/Framework/MockObject/Generator.php(231) : eval()'d code on line 452

Jenkins console: https://integration.wikimedia.org/ci/job/mwext-TwnMainPage-testextension-zend/9/console

Details

	Subject	Repo	Branch	Lines +/-
	Use concrete BagOStuff implementation for mock	mediawiki/extensions/TwnMainPage	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: rMEXT1a4c6ee3e6a1: Updated mediawiki/extensions Project: mediawiki/extensions/TwnMainPage…
rETWN295e10cf4b16: Use concrete BagOStuff implementation for mock
Mentioned Here: rMW61697bab1efd: Made BagOStuff::cas protected, which is just one merge() implementation

Event Timeline

• Jsahleen created this task.Feb 11 2015, 5:10 PM

• Jsahleen raised the priority of this task from to Needs Triage.

• Jsahleen updated the task description. (Show Details)

• Jsahleen added a project: MediaWiki-Core-Team.

• Jsahleen subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2015, 5:10 PM

• Jsahleen updated the task description. (Show Details)Feb 11 2015, 5:11 PM

• Jsahleen set Security to None.

• Jsahleen added a subscriber: Nikerabbit.

Legoktm triaged this task as High priority.Feb 11 2015, 5:18 PM

Legoktm edited projects, added MediaWiki-Core-Tests; removed MediaWiki-Core-Team.

Legoktm added a subscriber: aaron.

In mediawiki/core BagOStuff::cas() has been made protected (was public) with 61697bab1 / I3ef82226231f7e03f7493ae042cad22339f4c869 . Update the interface!

Nikerabbit claimed this task.Feb 12 2015, 2:05 PM

Nikerabbit added a project: MediaWiki-extensions-TwnMainPage.