Page MenuHomePhabricator

Extension Html2Wiki unable to clone on windows - Invalid path (contains separator ':')
Closed, ResolvedPublic

Description

The extension Html2Wiki contains a file named
modules/MediaWiki:Common.js

The colon makes this file a invalid filename on windows machine and that breaks cloning of mediawiki/extensions with the error message:
Git repository clone failed.
Invalid path (contains separator ':'): modules/MediaWiki:Common.js

Please rename the file. Thanks.

Event Timeline

Umherirrender raised the priority of this task from to Needs Triage.
Umherirrender updated the task description. (Show Details)
Umherirrender subscribed.
Aklapper triaged this task as Lowest priority.Feb 15 2015, 9:50 PM

Extension homepage provides no data where its bugtracker is and cannot find the author's account in Phabricator either, so this bug report might just rot.

(I've joined Phabricator, and) I just pushed a commit to fix this. The issue id is appended in the commit message, so that fix should get picked up by the Gerrit bot.

@freephile: I don't see anything listed in Wikimedia Gerrit with you as owner....

@Aklapper, I assumed the gerrit bot scans all commits on git.wikimedia.org I'm new to contributing here, so I'm not familiar with all the mechanics yet.

In any case, I pushed to this repo https://git.wikimedia.org/git/mediawiki/extensions/Html2Wiki.git and I tried to format the last line of my commit message so that this issue would be associated with the commit.

Here is the commit
https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FHtml2Wiki/f06f676edf635636628e34ddebf54c8019dfee24

And the commit message ended with
Fixes Bug: T89569

The previous file has been renamed to avoid the ':' character which is invalid as a filename character in Windows.

Umherirrender assigned this task to freephile.
Umherirrender set Security to None.

Thanks for the fix. The repo is now clonable under windows.

The Gerrit bot only looks for patches pushed against gerrit.wikimedia.org, but Html2Wiki seems to configurated to allow direct push to git without a review. In that cases the gerrit bot is not seeing the patch set.

And the commit message ended with
Fixes Bug: T89569

See http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines for future reference how to trigger a notification here in Phabricator :)