Page MenuHomePhabricator
Create Task
Maniphest T89708

Fail gracefully when call to get language pairs happen
Closed, ResolvedPublic
Actions

Description

Currently if the ajax call to get language pairs fails, "create new translation" button does nothing and this is in the console:

ext.cx.source.selector.js:46 Uncaught TypeError: Cannot read property 'length' of undefinedext.cx.source.selector.js:46 getAutonymsext.cx.source.selector.js:802 CXSourceSelector.renderext.cx.source.selector.js:77 (anonymous function)load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:3300 (anonymous function)load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:3143 jQuery.Callbacks.fireload.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:3255 jQuery.Callbacks.self.fireWithload.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:9309 doneload.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:9713 jQuery.ajaxTransport.send.callbackXMLHttpRequest.send (async)load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:9659 jQuery.ajaxTransport.sendload.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:9210 jQuery.extend.ajaxload.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:9356 jQuery.each.jQuery.(anonymous function)ext.cx.source.selector.js:123 CXSourceSelector.getLanguagePairsext.cx.source.selector.js:76 CXSourceSelector.initext.cx.source.selector.js:34 CXSourceSelectorext.cx.source.selector.js:923 (anonymous function)load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:384 jQuery.extend.eachload.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:136 jQuery.fn.jQuery.eachext.cx.source.selector.js:917 $.fn.cxSourceSelectorext.cx.dashboard.js:71 CXDashboard.listenext.cx.dashboard.js:30 CXDashboard.initext.cx.dashboard.js:24 CXDashboardext.cx.dashboard.js:80 (anonymous function)load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:384 jQuery.extend.eachload.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:136 jQuery.fn.jQuery.eachext.cx.dashboard.js:75 $.fn.cxDashboardext.cx.dashboard.js:95 (anonymous function)load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:3143 jQuery.Callbacks.fireload.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:3189 jQuery.Callbacks.self.addload.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:3423 jQuery.fn.readyload.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:2863 jQuery.fn.initload.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150217T02…:73 jQueryext.cx.dashboard.js:94 (anonymous function)ext.cx.dashboard.js:97 (anonymous function)

Details

SubjectRepoBranchLines +/-
Add the server down message to source selector module toomediawiki/extensions/ContentTranslationmaster+1 -0
When cxserver is not reachable show error message in dashboardmediawiki/extensions/ContentTranslationmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Feb 17 2015, 11:25 AM
Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added projects: ContentTranslation, ContentTranslation-Release4.
Nikerabbit subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2015, 11:25 AM
KartikMistry added subscribers: KartikMistry, • santhosh.Feb 17 2015, 11:27 AM
KartikMistry mentioned this in rOPUP707298b6c299: Beta: More correction to common.yaml formatting.Feb 17 2015, 11:42 AM
• santhosh claimed this task.Feb 18 2015, 4:40 AM
• santhosh triaged this task as Medium priority.
gerritbot added a project: Patch-For-Review.Feb 18 2015, 4:46 AM
gerritbot subscribed.

Change 191254 had a related patch set uploaded (by Santhosh):
When cxserver is not reachable show error message in dashboard

https://gerrit.wikimedia.org/r/191254

Patch-For-Review

• santhosh added a comment.Feb 18 2015, 4:47 AM

I added an error message when cxserver API call fails

pasted_file (220×1 px, 34 KB)

gerritbot added a comment.Feb 18 2015, 5:15 AM

Change 191254 merged by jenkins-bot:
When cxserver is not reachable show error message in dashboard

https://gerrit.wikimedia.org/r/191254

• santhosh mentioned this in rECTX84789f060ade: When cxserver is not reachable show error message in dashboard.Feb 18 2015, 5:15 AM
Nikerabbit added a comment.Feb 18 2015, 8:40 AM

Gerrit is wonky so I'm leaving my comment here:

This message is only included in the ext.cx.header module. I do not see direct dependency from source selector to that module, so I think it should be included in the messages for this module as well.

gerritbot added a comment.Feb 24 2015, 9:23 AM

Change 192518 had a related patch set uploaded (by Santhosh):
Add the server down message to source selector module too

https://gerrit.wikimedia.org/r/192518

Patch-For-Review

gerritbot added a comment.Feb 24 2015, 10:41 AM

Change 192518 merged by jenkins-bot:
Add the server down message to source selector module too

https://gerrit.wikimedia.org/r/192518

• santhosh mentioned this in rECTX340fd2dd227e: Add the server down message to source selector module too.Feb 24 2015, 10:41 AM
• santhosh closed this task as Resolved.Mar 3 2015, 4:58 AM
Arrbee moved this task from Needs Triage to Long term on the ContentTranslation board.Mar 5 2015, 8:21 AM
• santhosh mentioned this in rMEXTcf218950deb9: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Mar 11 2015, 6:26 AM
• santhosh mentioned this in rMEXT143e4408c633: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL