Page MenuHomePhabricator
Create Task
Maniphest T89928

Don't disable native object editing in IE and WebKit browsers
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Calling document#execCommand to turn off enableObjectResizing and enableInlineTableEditing is slow and not necessary except on Firefox, which is the only user-agent that has these on by default.

Details

SubjectRepoBranchLines +/-
Only call execCommand() on the surface in FirefoxVisualEditor/VisualEditormaster+9 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

ori created this task.Feb 19 2015, 2:47 AM
ori assigned this task to Catrope.
ori raised the priority of this task from to Needs Triage.
ori updated the task description. (Show Details)
ori added a project: VisualEditor-Performance.
ori subscribed.
Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 19 2015, 2:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF triaged this task as Medium priority.Feb 21 2015, 8:12 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Bug Fixes on the VisualEditor board.
Catrope added a subtask: T91460: Put jquery.client back in VE core.Mar 3 2015, 10:29 PM
Jdforrester-WMF closed subtask T91460: Put jquery.client back in VE core as Resolved.Mar 11 2015, 11:29 PM
gerritbot subscribed.Mar 11 2015, 11:35 PM

Change 196105 had a related patch set uploaded (by Catrope):
Only call execCommand() on the surface in Firefox

https://gerrit.wikimedia.org/r/196105

gerritbot added a project: Patch-For-Review.Mar 11 2015, 11:35 PM
Jdforrester-WMF moved this task from Bug Fixes to Blocked on the VisualEditor board.Mar 12 2015, 5:41 PM
Jdforrester-WMF closed this task as Resolved.Mar 12 2015, 10:35 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-03-18_(1.25wmf22), VisualEditor 2014/15 Q3 blockers; removed Patch-For-Review.
gerritbot added a comment.Mar 12 2015, 10:36 PM

Change 196105 merged by jenkins-bot:
Only call execCommand() on the surface in Firefox

https://gerrit.wikimedia.org/r/196105

Catrope mentioned this in rGVED681804ece2a6: Only call execCommand() on the surface in Firefox.Mar 12 2015, 10:36 PM
Jdforrester-WMF edited a custom field.Mar 13 2015, 1:56 AM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 15 2015, 3:20 AM
Krinkle moved this task from Backlog to Done on the VisualEditor-Performance board.Mar 19 2015, 10:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL