Argh. Thanks for catching this!
Since T86772, mentioning a project in a comment does not automatically add it to the associated projects of a task anymore, and I wasn't aware that gerritbot only adds a comment mentioning that project and does not really "associate" a project.

Project phid of Patch-For-Review in Wikimedia Phabricator seems to be

PHID-PROJ-onnxucoedheq3jevknyr

according to project.query; should be passed as phid in maniphest.update ?

Downstream code is at https://gerrit.wikimedia.org/r/#/admin/projects/operations/gerrit/plugins
Upstream project is at https://gerrit-review.googlesource.com/#/admin/projects/plugins/its-phabricator

Nope,

Body | is | #patch-for-review
Author | is any of | gerritbot

didn't work as seen in T87832. Because "Author" probably refered to initial task desc. Now trying with

CCs | include all of | gerritbot

though not convinced yet either if that'll trigger.

Not working. So I tried with "Body | contains | Patch-For-Review". Still not working (watching the feed: 90245; Feb 20, 7:01 PM), and checking the code in /src/applications/herald/adapter/HeraldManiphestTaskAdapter.php it only looks at the description:

case self::FIELD_BODY:
  return $this->getTask()->getDescription();

So it looks like we really have to fix this in its-phabricator instead and Herald cannot help. :(

Wondering if there is something like "action = project Patch-For-Review" to just add to puppet's modules/gerrit/files/its/action.config. Which requires some "project" action handler. /me getting lost in code. :-/

Once again a backwards incompatible update of the issue tracker without testing if bots still work? Ouch :-(

If no one comes up with a fix before that, I can start working on a fix on Wednesday.

Change 192613 had a related patch set uploaded (by QChris):
Upgrade phabricator plugins to add add-project action

https://gerrit.wikimedia.org/r/192613

Patch-For-Review

Change 192624 had a related patch set uploaded (by QChris):
Explicitly associate 'Patch-For-Review' project to tasks

https://gerrit.wikimedia.org/r/192624

Patch-For-Review

Change 192624 merged by Rush:
Explicitly associate 'Patch-For-Review' project to tasks

https://gerrit.wikimedia.org/r/192624

Change 192613 merged by Chad:
Upgrade phabricator plugins to add add-project action

https://gerrit.wikimedia.org/r/192613

oh the lovely times from bugzilla's gerritbot are back: one email for the comment, another one for the tag...

In T89967#1075229, @Se4598 wrote:

oh the lovely times from bugzilla's gerritbot are back: one email for the comment, another one for the tag...

Correct. Patches to rewrite the code welcome.