|operations/puppet||production||+2 -4||Explicitly associate 'Patch-For-Review' project to tasks|
Argh. Thanks for catching this!
Since T86772, mentioning a project in a comment does not automatically add it to the associated projects of a task anymore, and I wasn't aware that gerritbot only adds a comment mentioning that project and does not really "associate" a project.
Project phid of Patch-For-Review in Wikimedia Phabricator seems to be
according to project.query; should be passed as phid in maniphest.update ?
Downstream code is at https://gerrit.wikimedia.org/r/#/admin/projects/operations/gerrit/plugins
Upstream project is at https://gerrit-review.googlesource.com/#/admin/projects/plugins/its-phabricator
Looked a bit at the its-base source code in ./src/main/java/com/googlesource/gerrit/plugins/hooks/workflow/ActionExecutor.java and Wikimedia puppet's modules/gerrit/files/its/ and it looked easier to create a Herald rule (add Patch-For-Review project to ask when comment created by Gerritbot and comment contains Patch-For-Review) for the time being: H23.
Keeping this open as I want to check if this works.
Not working. So I tried with "Body | contains | Patch-For-Review". Still not working (watching the feed: 90245; Feb 20, 7:01 PM), and checking the code in /src/applications/herald/adapter/HeraldManiphestTaskAdapter.php it only looks at the description:
case self::FIELD_BODY: return $this->getTask()->getDescription();
So it looks like we really have to fix this in its-phabricator instead and Herald cannot help. :(
Wondering if there is something like "action = project Patch-For-Review" to just add to puppet's modules/gerrit/files/its/action.config. Which requires some "project" action handler. /me getting lost in code. :-/
Once again a backwards incompatible update of the issue tracker without testing if bots still work? Ouch :-(
If no one comes up with a fix before that, I can start working on a fix on Wednesday.