Page MenuHomePhabricator
Create Task
Maniphest T90232

Stray comma causes all kinds of failures in Civi records
Closed, DeclinedPublic
Actions

Description

Wow... steps to reproduce seem to be,

  • Create a new contribution from the CiviCRM GUI, and enter a comma in the "source" amount, e.g. "USD 123,456".

The contribution becomes uneditable, and toxic to the thank-you job...

https://civicrm.wikimedia.org/civicrm/contact/view/contribution?reset=1&action=update&id=11461418&cid=498872&context=contribution

Tried to add a no_thank_you reason, and...

Exception: "A fatal error was triggered"

#0 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/DAO.php(755): CRM_Core_Error::fatal()
#1 /srv/org.wikimedia.civicrm/civicrm/CRM/Contribute/Form/Contribution.php(1212): CRM_Core_DAO::getFieldValue("CRM_Price_DAO_Field", NULL, "price_set_id")
#2 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/Form.php(261): CRM_Contribute_Form_Contribution->postProcess()
#3 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/QuickForm/Action/Upload.php(151): CRM_Core_Form->mainProcess()
#4 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/QuickForm/Action/Upload.php(128): CRM_Core_QuickForm_Action_Upload->realPerform(Object(CRM_Contribute_Form_Contribution), "upload")
#5 /srv/org.wikimedia.civicrm/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Upload->perform(Object(CRM_Contribute_Form_Contribution), "upload")
#6 /srv/org.wikimedia.civicrm/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Contribute_Form_Contribution), "upload")
#7 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/Controller.php(310): HTML_QuickForm_Page->handle("upload")
#8 /srv/org.wikimedia.civicrm/civicrm/CRM/Contribute/Page/Tab.php(296): CRM_Core_Controller->run()
#9 /srv/org.wikimedia.civicrm/civicrm/CRM/Contribute/Page/Tab.php(353): CRM_Contribute_Page_Tab->edit()
#10 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/Invoke.php(220): CRM_Contribute_Page_Tab->run((Array:4), NULL)
#11 /srv/org.wikimedia.civicrm/civicrm/CRM/Core/Invoke.php(51): CRM_Core_Invoke::_invoke((Array:4))
#12 /srv/org.wikimedia.civicrm/civicrm/drupal/civicrm.module(500): CRM_Core_Invoke::invoke((Array:4))
#13 [internal function](): civicrm_invoke("contact", "view", "contribution")
#14 /srv/org.wikimedia.civicrm/drupal/includes/menu.inc(517): call_user_func_array("civicrm_invoke", (Array:3))
#15 /srv/org.wikimedia.civicrm/drupal/index.php(21): menu_execute_active_handler()
#16 {main}

Related Objects

Event Timeline

awight created this task.Feb 20 2015, 5:27 PM
awight raised the priority of this task from to Needs Triage.
awight updated the task description. (Show Details)
awight added a project: Wikimedia-Fundraising.
awight subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2015, 5:27 PM
awight added a comment.Feb 20 2015, 5:32 PM

So far, I think this might have been something related to a comma in the contribution_source field, which might be breaking hooks?

awight renamed this task from Fatal error while editing a contribution to Stray comma causes all kinds of failures.Feb 20 2015, 5:37 PM
awight updated the task description. (Show Details)
awight set Security to None.
• atgo triaged this task as Low priority.Feb 23 2015, 9:38 PM
• atgo added subscribers: CaitVirtue, RLewis, • atgo.

@RLewis @CaitVirtue have you ever run into this?

Marking as low priority unless our users are running into the problem.

RLewis added a comment.Feb 23 2015, 10:58 PM

@atgo yes this is something I have run into when I hand enter donations in Civi, it isn't a huge issue now I know why this happens.

• atgo merged a task: T106568: Unfathomable comma issue makes it annoying to edit contributions >= $1000.Jul 30 2015, 10:11 PM
• atgo edited projects, added Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog; removed Wikimedia-Fundraising.
• atgo renamed this task from Stray comma causes all kinds of failures to Stray comma causes all kinds of failures in Civi records.Jul 31 2015, 9:11 PM
• atgo moved this task from Triage to Old Unscheduled (prior to 2019) on the Fundraising-Backlog board.
Eileenmcnaughton subscribed.Oct 14 2015, 12:53 AM

I tried to replicate this on 4.6 staging (primarily to test 4.6) and I couldn't save that data because code has been added to enforce the format is correct.

However, I also tested on http://d46.demo.civicrm.org/ and could not replicate there so I suspect this will be closable after the upgrade

Eileenmcnaughton added a comment.Nov 17 2015, 5:13 AM

I think this is a duplicate of https://phabricator.wikimedia.org/T118216

• atgo added a comment.Nov 17 2015, 4:57 PM

@Eileenmcnaughton there's a "merge duplicates in" button in the task
options so you can collapse them.

• atgo added a comment.Nov 17 2015, 7:10 PM

@awight thought these weren't duplicates for reasons?

• atgo unsubscribed.Mar 30 2016, 10:07 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:40 PM
Eileenmcnaughton closed this task as Declined.May 2 2023, 2:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL