Page MenuHomePhabricator
Create Task
Maniphest T90780

ApiBlock throws exception when re-blocking non-blocked user
Closed, ResolvedPublic
Actions

Description

ApiBlock returns the following error instead of a proper JSON result when re-blocking a user who isn't already blocked:

"Catchable fatal error: Argument 1 passed to Block::equals() must be an instance of Block, null given, called in /var/www/w24/includes/specials/SpecialBlock.php on line 725 and defined in /var/www/w24/includes/Block.php on line 192"

Details

SubjectRepoBranchLines +/-
Made Block::insert handle expired rowsmediawiki/coremaster+22 -8
Customize query in gerrit

Related Objects

Event Timeline

RobinHood70 created this task.Feb 25 2015, 8:27 PM
RobinHood70 raised the priority of this task from to Needs Triage.
RobinHood70 updated the task description. (Show Details)
RobinHood70 subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2015, 8:27 PM
Legoktm added a project: MediaWiki-Action-API.Feb 25 2015, 8:28 PM
Legoktm set Security to None.
Anomie subscribed.Feb 25 2015, 8:49 PM

Not really an API bug, SpecialBlock shouldn't be throwing an exception in the first place.

Anomie added a comment.Feb 25 2015, 9:17 PM

What's going on here is this:

  1. User::loadFromDatabase() auto-starts a transaction on master, if User::loadFromCache() misses.
  2. Block::insert() calls Block::purgeExpired() to try to delete expired blocks before inserting. But since Gerrit change 59794 that uses onTransactionIdle, so it doesn't actually purge anything due to the transaction in progress from step 1.
  3. Block::insert() tries to insert the new block, but fails due to the expired block that didn't get deleted in step 2.
  4. SpecialBlock::processForm() tries to load the existing block. But Block::newLoad sees that the block it's going to load is expired and so doesn't return it (it also deletes it from the database).
  5. So SpecialBlock::processForm() gets null for the current block, and boom.
Anomie edited projects, added MediaWiki-User-management; removed MediaWiki-Action-API.Feb 25 2015, 9:18 PM
Anomie added subscribers: aaron, tstarling.
Aklapper triaged this task as Medium priority.Feb 26 2015, 2:07 PM
gerritbot subscribed.Apr 6 2015, 10:13 PM

Change 202255 had a related patch set uploaded (by Aaron Schulz):
Made Block::insert handle expired rows

https://gerrit.wikimedia.org/r/202255

gerritbot added a project: Patch-For-Review.Apr 6 2015, 10:13 PM
gerritbot added a comment.Apr 7 2015, 10:03 AM

Change 202255 merged by jenkins-bot:
Made Block::insert handle expired rows

https://gerrit.wikimedia.org/r/202255

aaron mentioned this in rMWf68e3864ba03: Made Block::insert handle expired rows.Apr 7 2015, 10:03 AM
Anomie closed this task as Resolved.Apr 7 2015, 1:57 PM
Anomie assigned this task to aaron.

The fix here should be deployed to WMF wikis with 1.26wmf1, see https://www.mediawiki.org/wiki/MediaWiki_1.26/Roadmap for the schedule.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits