Keep in mind, just in case it might be useful, that since action=editlist accepts generator, you could add all (up to a limit, but continuable) results of the generator to a list. Including the search results (since search is a list generator)

@MSyed and @JKatzWMF to review and update the workflow.

@msyed-- done button feels overloaded here. If you're in search and want to exit it, we should consider another method?

@mysed @jdlrobson--I think the acceptance criteria clarify that when you click on an overlay that is what closes search. Or hitting back button.

Change 201362 had a related patch set uploaded (by Robmoen):
WIP: Add to collection from search

https://gerrit.wikimedia.org/r/201362

Making good progress with this. Will split into 2 patches - first will allow you to remove existing members, second will allow you to search and add new members. The search is going to be tricky as I'm not quite sure how to do it with our existing API...

Please add a separate issue for the api - i propose a new prop module for this

action=query & titles=pageA|pageB & prop=listmembership & lsmid=<listID>

Resulting in

{ 'query': { 'pages': [ {
   'id':10, 'title':'pageA', listmembership:true
}, {
   'id':15, 'title':'pageB', listmembership:false
}}]}}

Because its a prop, it can easily use a generator to supply list of titles. Can also do lsmlabel=label, and possibly even other user's public lists with lsmowner=User

Change 202935 had a related patch set uploaded (by Jdlrobson):
Add ability to remove/add new members to a collection via search

https://gerrit.wikimedia.org/r/202935

@MSyed @JKatzWMF @Jdlrobson @rmoen re: consistency when saving results.

If I'm understanding right what we are doing, the title/description editing saves when you hit next, see the collection in edit mode, and then hit "Done".

Au contraire, if you deselect/select it actually saves that removal/addition going to the API immediately.

What are we doing? let's try to be consistent. Are we delaying all editing of the collection until "Done" is hit, or are we actually performing little edits as the user goes modifying the collection?

I'm all in for live little edits all over the place (for that we would have to change the saving of title/description to the "Next" click instead of the "Done" click and probably call it "Save" instead of "Next".

Plz feedback, lets move this along

Even though this is merged, I still want to talk about the consistency of the editing actions (live / deferred)

Moving to -1 because of the next patch : https://gerrit.wikimedia.org/r/#/c/202935/

Change 201362 merged by jenkins-bot:
Edit collection overlay allows you to manage existing members

https://gerrit.wikimedia.org/r/201362

I setup T95598 to discuss @Jhernandez concerns.

https://gerrit.wikimedia.org/r/#/c/202935/ handles the rest

Change 202935 merged by jenkins-bot:
Add ability to remove/add new members to a collection via search

https://gerrit.wikimedia.org/r/202935