Page MenuHomePhabricator
Create Task
Maniphest T91245

setupSlugs is called twice during ContentBranchNode setup
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

While setting up a ContentBranchNode, there are two calls to setupSlugs: one from onSplice when the child nodes are first spliced in, and another one from renderContents when the contents are first rendered.

Details

SubjectRepoBranchLines +/-
ce.ContentBranchNode: Prevent setupSlugs() from being called twiceVisualEditor/VisualEditormaster+9 -8
[BREAKING CHANGE] Split setupSlugs in to setup(Block|Inline)SlugsVisualEditor/VisualEditormaster+29 -10
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Mar 2 2015, 10:35 AM
Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added projects: VisualEditor, VisualEditor-ContentEditable, VisualEditor-Performance.
Catrope added subscribers: Catrope, dchan, ori.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2015, 10:35 AM
gerritbot subscribed.Mar 2 2015, 10:35 AM

Change 193787 had a related patch set uploaded (by Catrope):
[WIP] ce.ContentBranchNode: Prevent setupSlugs() from being called twice

https://gerrit.wikimedia.org/r/193787

gerritbot added a project: Patch-For-Review.Mar 2 2015, 10:35 AM
Jdforrester-WMF triaged this task as High priority.Mar 2 2015, 3:38 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Bug Fixes on the VisualEditor board.Mar 2 2015, 4:13 PM
Jdforrester-WMF assigned this task to dchan.Mar 2 2015, 11:40 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Polish on the VisualEditor 2014/15 Q3 blockers board.Mar 4 2015, 4:16 PM
Jdforrester-WMF moved this task from Bug Fixes to Blocked on the VisualEditor board.Mar 12 2015, 5:42 PM
Jdforrester-WMF reassigned this task from dchan to • TrevorParscal.Mar 27 2015, 9:51 PM
• TrevorParscal reassigned this task from • TrevorParscal to • Esanders.Mar 31 2015, 5:23 PM
gerritbot added a comment.Apr 1 2015, 3:45 PM

Change 201205 had a related patch set uploaded (by Esanders):
[BREAKING CHANGE] Split setupSlugs in to setup(Block|Inline)Slugs

https://gerrit.wikimedia.org/r/201205

• TrevorParscal edited projects, added VisualEditor 2014/15 Q4 blockers; removed VisualEditor 2014/15 Q3 blockers.Apr 1 2015, 6:03 PM
• TrevorParscal moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.
Jdforrester-WMF moved this task from Backlog to Doing on the VisualEditor 2014/15 Q4 blockers board.Apr 1 2015, 6:13 PM
gerritbot added a comment.Apr 1 2015, 7:05 PM

Change 201205 merged by jenkins-bot:
[BREAKING CHANGE] Split setupSlugs in to setup(Block|Inline)Slugs

https://gerrit.wikimedia.org/r/201205

• Esanders mentioned this in rGVEDf2086423e868: [BREAKING CHANGE] Split setupSlugs in to setup(Block|Inline)Slugs.Apr 1 2015, 7:05 PM
gerritbot added a comment.Apr 2 2015, 5:13 PM

Change 193787 abandoned by Catrope:
ce.ContentBranchNode: Prevent setupSlugs() from being called twice

https://gerrit.wikimedia.org/r/193787

Jdforrester-WMF closed this task as Resolved.Apr 2 2015, 5:23 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-04-08_(1.26wmf1); removed Patch-For-Review.
Jdforrester-WMF moved this task from Doing to Done on the VisualEditor 2014/15 Q4 blockers board.
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 8 2015, 10:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits