Page MenuHomePhabricator

Tests directory subtly missing from core/extension releases
Closed, ResolvedPublic

Description

The tests/ directory in core (and in some extensions packaged with core) are missing. This was introduced in
change I341892c3ccfb3c2ac8eee565205c4c8164af5a72

The tests are gone, but the code that looks for them is not. This means *all unit-tests are broken* in releases of MediaWiki. Including the unit-testing registration but not including the tests/ directory is wrong. In this state the code is not only is the incomplete, it is inconsistent -- there is code that breaks when run (references to files that do not exist.) Without these files no-one can run any unit-tests.

In my opinion, a robust open source software package such as MediaWiki should be proud to ship its unit-tests. The 4MB of tests don't significantly contribute to the size of the release (some 80MB+.) While some people might checkout the code from git to run the unit-tests, many do not. This doesn't fix the fact that the current code in MW core is broken in the releases.

Event Timeline

AlephNull claimed this task.
AlephNull raised the priority of this task from to Needs Triage.
AlephNull updated the task description. (Show Details)
AlephNull added subscribers: AlephNull, MarkAHershberger.

Change 194157 had a related patch set uploaded (by AlephNull):
Removing ignores for testing-related directorys

https://gerrit.wikimedia.org/r/194157

hashar triaged this task as Medium priority.Mar 3 2015, 10:14 PM
hashar moved this task from INBOX to In-progress on the Release-Engineering-Team board.

Change 194157 merged by jenkins-bot:
make-release: Removing ignores for testing-related directories

https://gerrit.wikimedia.org/r/194157

This was long since fixed, rc.0 should've already had them reinstated.