[Regression wmf20] Table gets broken while changing the cell type after a merge cell operation
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

1.Open a page with VE
2.Insert a table
3.Select all four cells from a row which are content cells and merge them
4.Now change the type of cell to header

Observed Result:
The table gets broken , the last three cells of that row disappear.

See the video capture attached

broken_table.mov4 MBDownload

Details

Subject	Repo	Branch	Lines +/-
Create CE view initialization event for when $element is created	VisualEditor/VisualEditor	master	+77 -48
Followup 11f507a98f62: also restore rowspan and colspan on TableCellNodes	VisualEditor/VisualEditor	wmf/1.25wmf20	+20 -0
Followup 11f507a98f62: also restore rowspan and colspan on TableCellNodes	VisualEditor/VisualEditor	master	+20 -0

Customize query in gerrit

Related Objects

Mentioned In: rGVEDecd7944f3a4a: Followup 11f507a98f62: also restore rowspan and colspan on TableCellNodes
rGVEDbc8b38893c72: Followup 11f507a98f62: also restore rowspan and colspan on TableCellNodes
rGVED98b253d1f979: Followup 11f507a98f62: also restore rowspan and colspan on TableCellNodes
Mentioned Here: rGVED11f507a98f62: Don't call .addClass() in CE nodes' setup handlers

Event Timeline

Ryasmeen created this task.Mar 6 2015, 10:43 PM

Ryasmeen raised the priority of this task from to Needs Triage.

Ryasmeen updated the task description. (Show Details)

Ryasmeen added a project: VisualEditor.

Ryasmeen subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2015, 10:43 PM

Ryasmeen renamed this task from [Regression wmf 20] Table gets broken after changing the cell type for a merge cell operation to [Regression wmf 20] Table gets broken while changing the cell type after a merge cell operation.Mar 6 2015, 10:44 PM

Ryasmeen triaged this task as High priority.

Ryasmeen set Security to None.

Ryasmeen moved this task from To Triage to External and Administrivia on the VisualEditor board.

Catrope assigned this task to • Esanders.Mar 6 2015, 10:47 PM

git blame points the finger at Roan: https://gerrit.wikimedia.org/r/#/c/193813/

In TableCellNode we call updateTagName which uses setup/teardown to ensure attributes are set on the new element.

@Catrope: I think your setup/teardown commit didn't address the problem properly as evidenced by the fact that one of your comments includes the word 'duplicate'. There should be an initialise element method that should be called on construction or when $element is modified (e.g. in GCN or updateTagName).

• Esanders added a subscriber: Catrope.Mar 8 2015, 10:40 AM

Change 195222 had a related patch set uploaded (by Catrope):
Followup 11f507a98f62: also restore rowspan and colspan on TableCellNodes

https://gerrit.wikimedia.org/r/195222

gerritbot added a project: Patch-For-Review.Mar 9 2015, 10:26 AM

Change 195228 had a related patch set uploaded (by Esanders):
Create CE view initialization event for when $element is created

https://gerrit.wikimedia.org/r/195228

Jdforrester-WMF renamed this task from [Regression wmf 20] Table gets broken while changing the cell type after a merge cell operation to [Regression wmf20] Table gets broken while changing the cell type after a merge cell operation.Mar 9 2015, 3:06 PM

Jdforrester-WMF reassigned this task from • Esanders to Catrope.

Jdforrester-WMF added projects: VisualEditor-DataModel, VisualEditor-Tables.

Change 195286 had a related patch set uploaded (by Jforrester):
Followup 11f507a98f62: also restore rowspan and colspan on TableCellNodes

https://gerrit.wikimedia.org/r/195286

Change 195222 merged by jenkins-bot:
Followup 11f507a98f62: also restore rowspan and colspan on TableCellNodes

https://gerrit.wikimedia.org/r/195222

Catrope mentioned this in rGVED98b253d1f979: Followup 11f507a98f62: also restore rowspan and colspan on TableCellNodes.Mar 9 2015, 4:16 PM

Change 195286 merged by jenkins-bot:
Followup 11f507a98f62: also restore rowspan and colspan on TableCellNodes

https://gerrit.wikimedia.org/r/195286

Jdforrester-WMF mentioned this in rGVEDbc8b38893c72: Followup 11f507a98f62: also restore rowspan and colspan on TableCellNodes.Mar 9 2015, 4:17 PM

Jdforrester-WMF closed this task as Resolved.Mar 9 2015, 10:35 PM

Jdforrester-WMF edited projects, added WMF-deploy-2015-03-04_(1.25wmf20), WMF-deploy-2015-03-11_(1.25wmf21), VisualEditor 2014/15 Q3 blockers; removed Patch-For-Review.

Jdforrester-WMF edited a custom field.

checked the fix in Betalabs and test2

Ryasmeen added a project: Verified-in-Phase0.Mar 10 2015, 1:07 AM

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 10 2015, 3:46 PM

Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 10 2015, 4:15 PM

Catrope mentioned this in rGVEDecd7944f3a4a: Followup 11f507a98f62: also restore rowspan and colspan on TableCellNodes.Mar 12 2015, 4:05 AM

Ryasmeen added a project: Verified-in-Phase2.Mar 12 2015, 7:10 PM

Change 195228 abandoned by Jforrester:
Create CE view initialization event for when $element is created

Reason:
We're going with Roan's approach, apparently.