Please see details:
https://wikitech.wikimedia.org/wiki/Analytics/Unique_clients/Last_visit_solution
Please see details:
https://wikitech.wikimedia.org/wiki/Analytics/Unique_clients/Last_visit_solution
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
operations/puppet | production | +114 -0 | Adding a Last-Access cookie to text and mobile requests |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | None | T88647 {bear} Last Access Counts | |||
Declined | • kevinator | T88813 Implement Last-Access cookie [34 pts] {bear} | |||
Resolved | • kevinator | T92435 Code changes in VCL to add a Last-Access cookie to track "top domain" uniques [13 pts] {bear} |
Change 196009 had a related patch set uploaded (by Nuria):
Adding a Last-Access cookie to text and mobile requests
Change 196009 had a related patch set uploaded (by BBlack):
Adding a Last-Access cookie to text and mobile requests
^ Aside from the technical-level work in PS10, a few other things have changed that affect other code, and I have a few further questions, etc:
PS11 refactors a bit further to work around the Cookie-access issues by splitting into recv and deliver halves, which I think was the last real outstanding issue in the way of this code working in prod.
I've tested the core code of PS11 in an isolated default varnish server and confirmed that it seems to behave as expected for real requests as well, but not yet in beta with a full load of normal VCL alongside it.
The 3 questions/points above still need clarification.
Thanks Grace. Brandon, I'm getting caught up on this and will respond shortly. I'll own the patch going forward. Btw, if you need me I'm milimetric on IRC as well, and I'm always in the ops channel.
Brandon, I've commented on the patch, I basically agreed with your first two changes and also agreed with your proposed third change. But I didn't update the patch. Let me know if you'd rather I take a shot next time, I'm happy to do that. Thanks very much for the thoughtful work.
hey @BBlack, when will this be deployed to all varnishes? I'm getting really excited we're so close to being able to generate a report.
This is running now for the beta text varnish, e.g. on http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page . You can look at the headers and play with sending it various cookies there (and even see the X-Analytics output in the response headers as well, of course). If we're in agreement that it functions correctly there, we can push the VCL part to prod either "very soon", or Monday. Generally things like this on Friday afternoons are frowned on at the ops level.
Brandon, that looks great. I'm going to mark this as resolved and move it into our "ready to deploy" column. Let us know if anything goes wrong with the deployment Monday.
Change 196009 merged by BBlack:
Adding a Last-Access cookie to text and mobile requests