[4.0.7.5] Lead Image & Image Gallery features broken for migrated articles
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• BGerstle-WMF
	Mar 13 2015, 11:19 PM

Description

Wikimedia Mobile TestFlight Beta 4.0.7.5

Steps to reproduce

Download app from the app store
1. Or, check out the old version of the project at git SHA: 056211487f3f4e41726c0e301f34b3c5ba4cf13e
Save & visit pages
Note the saved & visited pages
Download the Wikimedia Mobile TF Beta 4.0.7.5
!! Double check saved & recent pages are accurate
Click on one of the saved/recent pages to view it

Expected Results:
Lead image is present for the article (if it has one). Image gallery functions as normal (opens the selected image and shows the rest of the article's images).

Actual results:
Lead image does not appear, and image gallery only shows the first image, w/o any other images. Requires a refresh via pull-to-refresh to restore functionality.

Details

	Subject	Repo	Branch	Lines +/-
	set article imageURL and save image list	apps/ios/wikipedia	master	+1 K -644

Customize query in gerrit

Related Objects

Mentioned In: rAPIW9f94ea4df018: set article imageURL and save image list

Event Timeline

• BGerstle-WMF created this task.Mar 13 2015, 11:19 PM

• BGerstle-WMF raised the priority of this task from to Needs Triage.

• BGerstle-WMF updated the task description. (Show Details)

• BGerstle-WMF added a project: Wikipedia-iOS-App-Backlog.

• BGerstle-WMF added subscribers: • BGerstle-WMF, dr0ptp4kt, • Deskana.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2015, 11:19 PM

It seems that opening saved/recent pages the second etc time displays the leading image (iPad mini 8.2 with Beta 4.0.7.5 ).

@Etonkovidova that sounds inconsistent with what I noticed, which is that no matter how many times I opened the article from saved/recent that the lead image & gallery were broken. Only after refreshing the article did I see the lead image & gallery function properly. Admittedly, the refresh ''could'' happen as a result of opening the article, but I don't remember exactly how that's supposed to work.

It's not the biggest deal that saved pages are not showing lead images if they're migrated, because they didn't have lead images before.

@BGerstle-WMF: Are you still working on this?

• Deskana moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Mar 16 2015, 9:47 PM

@Deskana haven't started working on it yet. Was planning on picking it up soon, though.

• BGerstle-WMF claimed this task.Mar 20 2015, 11:44 PM

• BGerstle-WMF raised the priority of this task from Low to High.

• BGerstle-WMF added a project: Mobile-App-Sprint-53-iOS.

• BGerstle-WMF set Security to None.

• BGerstle-WMF moved this task from To Do to Code Review on the Mobile-App-Sprint-53-iOS board.

• BGerstle-WMF updated the task description. (Show Details)Mar 20 2015, 11:54 PM

Change 198432 had a related patch set uploaded (by Bgerstle):
set article imageURL and save image list

https://gerrit.wikimedia.org/r/198432

gerritbot added a project: Patch-For-Review.Mar 24 2015, 1:24 PM

Change 198432 merged by Dr0ptp4kt:
set article imageURL and save image list

https://gerrit.wikimedia.org/r/198432

• BGerstle-WMF moved this task from Code Review to Ready for Signoff on the Mobile-App-Sprint-53-iOS board.Mar 25 2015, 9:57 PM

• BGerstle-WMF mentioned this in rAPIW9f94ea4df018: set article imageURL and save image list.Mar 25 2015, 9:57 PM

MBinder_WMF added a project: Essential-Work.Aug 25 2015, 4:28 PM

• JMinor closed this task as Resolved.Nov 24 2015, 8:24 PM

• JMinor subscribed.

[4.0.7.5] Lead Image & Image Gallery features broken for migrated articlesClosed, ResolvedPublicActions