Page MenuHomePhabricator
Create Task
Maniphest T92736

Allow amended patch sets without rebase with gerrit patch uploader
Open, MediumPublic
Actions

Description

When reviewing a patch set it is sometimes necessary for the commiter to amend the patch set. In this situation it is for the reviewer very helpful to set the "Reference Version" for the diff against the previous (reviewed) patch set. But patch sets for gerrit patch uploader seems to need always a rebase to current master which breaks the diff and makes the work of reviewer harder (at least for me).

It is possible to allow the upload of amended patch sets against the same parent as the existing patch set? Like normally done by commiter when not using gerrit patch uploader?

Event Timeline

Umherirrender created this task.Mar 14 2015, 5:22 PM
Umherirrender raised the priority of this task from to Needs Triage.
Umherirrender updated the task description. (Show Details)
Umherirrender added a project: Tool-Gerrit-Patch-Uploader.
Umherirrender added subscribers: Umherirrender, Fomafix.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2015, 5:22 PM
valhallasw triaged this task as Medium priority.Mar 22 2015, 7:46 PM
valhallasw subscribed.

I see why this would be useful, but it's actually somewhat hard to implement. The way the uploader works is as follows:

  1. user submits patch
  2. gpu runs git clone
  3. gpu applies patch
  4. gpu runs 'git review'

To make this work, the gpu should parse the patch message, get the change id, check out the base revision, then apply the new patch and review.

The easiest option for this might be to add a 'base revision' input to the form. That would also allow users to more easily submit a patch that no longer applies cleanly. It would still need to fill that base revision input somehow, though.

Umherirrender unsubscribed.Jul 5 2015, 7:23 PM
Ricordisamoa subscribed.Jul 17 2015, 6:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits