Page MenuHomePhabricator
Create Task
Maniphest T92781

EditTools issues on Special:Upload
Closed, ResolvedPublic
Actions

Description

:ro:MediaWiki:Edittools does not work on :ro:Special:Upload. Namely elements are not clickable.

See also: https://phabricator.wikimedia.org/T88922#1063030

Details

SubjectRepoBranchLines +/-
Remove inline event handler js from charinsertmediawiki/extensions/CharInsertmaster+93 -25
Customize query in gerrit

Related Objects
Search...

Event Timeline

XXN created this task.Mar 15 2015, 10:31 PM
XXN raised the priority of this task from to Unbreak Now!.
XXN updated the task description. (Show Details)
XXN added projects: JavaScript, Contributors-Team.
XXN subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2015, 10:31 PM
TheDJ closed this task as a duplicate of T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used.Mar 15 2015, 10:35 PM
XXN mentioned this in T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used.Oct 29 2015, 6:25 PM
XXN reopened this task as Open.Oct 29 2015, 6:35 PM
XXN updated the task description. (Show Details)
XXN set Security to None.

This task was closed as a duplicate of T88922. Now T88922 was closed as resolved but this bug still actual. This issue persists for several months, since winter-spring of 2015. It's time to fix it somehow!

matmarex added a subtask: T66969: When a message requires modules load the modules on parse.Oct 30 2015, 12:11 AM
matmarex added a subtask: T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used.
matmarex subscribed.

T88922 was one of the problems here, but T66969 is another and it's more difficult to fix.

I don't think this warrants "Unbreak Now!" priority, though. I recognize that this is an annoying issue, but there are far more broken things out there ;)

matmarex lowered the priority of this task from Unbreak Now! to Medium.Oct 30 2015, 12:13 AM
matmarex edited projects, added CharInsert; removed Contributors-Team.
PeterBowman reopened subtask T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used as Open.Mar 2 2016, 8:29 PM
matmarex closed this task as Resolved.Mar 3 2016, 7:42 PM
matmarex assigned this task to Bawolff.
matmarex closed subtask T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used as Resolved.
matmarex added a project: MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)).

This should be fixed by rECHIb2f7c4c507e5: Remove inline event handler js from charinsert (it's not live yet). Please reopen if this is still occuring after the 1.27.0-wmf.16 deployment next week (see https://www.mediawiki.org/wiki/MediaWiki_1.27/Roadmap for dates).

matmarex reopened this task as Open.Mar 12 2016, 12:51 PM
matmarex removed Bawolff as the assignee of this task.
matmarex removed a project: MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)).
matmarex added a subscriber: Bawolff.

Reverted due to T129524: Inserting via MediaWiki:Edittools no longer working :(

matmarex reopened subtask T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used as Open.Mar 12 2016, 12:51 PM
gerritbot subscribed.May 16 2016, 12:33 PM

Change 288922 had a related patch set uploaded (by Brian Wolff):
[DO NOT MERGE] Remove inline event handler js from charinsert

https://gerrit.wikimedia.org/r/288922

gerritbot added a project: Patch-For-Review.May 16 2016, 12:33 PM
Danny_B mentioned this in E196: Code Review Office Hours.May 25 2016, 11:20 AM
gerritbot added a comment.May 26 2016, 11:12 PM

Change 288922 merged by jenkins-bot:
Remove inline event handler js from charinsert

https://gerrit.wikimedia.org/r/288922

matmarex closed this task as Resolved.May 27 2016, 12:09 PM
matmarex assigned this task to Bawolff.
matmarex closed subtask T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used as Resolved.
XXN reopened this task as Open.May 28 2016, 8:56 PM

Still does not work.

TheDJ closed this task as Resolved.May 28 2016, 9:02 PM
TheDJ edited projects, added MW-1.28-release (WMF-deploy-2016-05-31_(1.28.0-wmf.4)); removed Patch-For-Review.
TheDJ subscribed.

@XXN Resolved does not mean deployed to all websites. This will start becoming available no earlier than tuesday 31st of may and if all goes according to plan, it will likely be available everywhere after thursday.

Aklapper added a comment.May 29 2016, 8:36 PM

@XXN: See https://www.mediawiki.org/wiki/Bug_management/Bug_report_life_cycle for the meaning of "resolved" and https://wikitech.wikimedia.org/wiki/Deployments for info on deployments on Wikimedia sites. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits