Page MenuHomePhabricator

"Maximum number of concurrent uploads" (upwiz_maxsimultaneous) isn't respected
Closed, ResolvedPublic

Description

I've tried that preference on my vm and it seems like it doesn't work at all. If I set it to 1 sometimes it will try to upload the first file on its own, but then after this one is done, inevitably it will upload the rest of the batch at once.

Event Timeline

Gilles raised the priority of this task from to Needs Triage.
Gilles updated the task description. (Show Details)
Gilles added a project: UploadWizard.
Gilles added a subscriber: Gilles.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MarkTraceur claimed this task.
MarkTraceur added a subscriber: MarkTraceur.

I think this is fixed, but I can't be sure.

Local uploads are deceptively fast, so the initial report (from "[gilles's] vm") may have just been a matter of perception.

In any case, the final form of the massive refactor *seems* like it has no way to exceed the configuration variable in question, so until we see reports to the contrary, I'm closing this.

It wasn't fixed last time I checked. It's respected in the final step (publishing), but not the first (uploading).

It's the same code enforcing it in both places, so I'm not sure how that's possible

Definitely not fixed.

matmarex raised the priority of this task from Low to High.
matmarex set Security to None.
matmarex renamed this task from "Maximum number of concurrent upload" isn't respected to "Maximum number of concurrent uploads" (upwiz_maxsimultaneous) isn't respected.Feb 16 2016, 2:13 AM

Change 271819 had a related patch set uploaded (by Bartosz Dziewoński):
uw.controller.Step: Don't allow more than one transition to be in progress

https://gerrit.wikimedia.org/r/271819

Change 271820 had a related patch set uploaded (by Bartosz Dziewoński):
Ugly hacks to make file uploads progress look better

https://gerrit.wikimedia.org/r/271820

Change 271819 merged by jenkins-bot:
uw.controller.Step: Don't allow more than one transition to be in progress

https://gerrit.wikimedia.org/r/271819

Change 271934 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "uw.controller.Step: Don't allow more than one transition to be in progress"

https://gerrit.wikimedia.org/r/271934

Change 271934 merged by jenkins-bot:
Revert "uw.controller.Step: Don't allow more than one transition to be in progress"

https://gerrit.wikimedia.org/r/271934

Change 271820 abandoned by Bartosz Dziewoński:
Ugly hacks to make file uploads progress look better

Reason:
Dependency was reverted.

https://gerrit.wikimedia.org/r/271820

OK, that didn't work out. I'll give it a think and try again later.

Change 277847 had a related patch set uploaded (by Bartosz Dziewoński):
uw.controller.Step: Refactor simultaneous transitions

https://gerrit.wikimedia.org/r/277847

Change 277847 merged by jenkins-bot:
uw.controller.Step: Refactor simultaneous transitions

https://gerrit.wikimedia.org/r/277847

Change 280339 had a related patch set uploaded (by Bartosz Dziewoński):
uw.controller.Step: Refactor simultaneous transitions

https://gerrit.wikimedia.org/r/280339

Change 280339 merged by jenkins-bot:
uw.controller.Step: Refactor simultaneous transitions

https://gerrit.wikimedia.org/r/280339