Page MenuHomePhabricator
Create Task
Maniphest T92809

"Maximum number of concurrent uploads" (upwiz_maxsimultaneous) isn't respected
Closed, ResolvedPublic
Actions

Description

I've tried that preference on my vm and it seems like it doesn't work at all. If I set it to 1 sometimes it will try to upload the first file on its own, but then after this one is done, inevitably it will upload the rest of the batch at once.

Details

SubjectRepoBranchLines +/-
uw.controller.Step: Refactor simultaneous transitionsmediawiki/extensions/UploadWizardwmf/1.27.0-wmf.19+755 -132
uw.controller.Step: Refactor simultaneous transitionsmediawiki/extensions/UploadWizardmaster+755 -132
Ugly hacks to make file uploads progress look bettermediawiki/extensions/UploadWizardmaster+16 -1
Revert "uw.controller.Step: Don't allow more than one transition to be in progress"mediawiki/extensions/UploadWizardmaster+1 -20
uw.controller.Step: Don't allow more than one transition to be in progressmediawiki/extensions/UploadWizardmaster+20 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Gilles created this task.Mar 16 2015, 8:32 AM
• Gilles raised the priority of this task from to Needs Triage.
• Gilles updated the task description. (Show Details)
• Gilles added a project: UploadWizard.
• Gilles subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptMar 16 2015, 8:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Gilles mentioned this in T92801: UploadWizard does not preserve the order of the images between upload and later steps.Mar 17 2015, 8:19 AM
MarkTraceur added a parent task: T96907: Clean up possible refactor-related regressions.Apr 22 2015, 8:39 PM
Jdforrester-WMF triaged this task as Low priority.Sep 4 2015, 6:56 PM
Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptSep 4 2015, 6:56 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 7:02 PM
MarkTraceur closed this task as Resolved.Dec 7 2015, 5:14 PM
MarkTraceur claimed this task.
MarkTraceur subscribed.

I think this is fixed, but I can't be sure.

Local uploads are deceptively fast, so the initial report (from "[gilles's] vm") may have just been a matter of perception.

In any case, the final form of the massive refactor *seems* like it has no way to exceed the configuration variable in question, so until we see reports to the contrary, I'm closing this.

matmarex subscribed.Dec 7 2015, 5:15 PM

It wasn't fixed last time I checked. It's respected in the final step (publishing), but not the first (uploading).

MarkTraceur added a comment.EditedDec 7 2015, 5:29 PM

It's the same code enforcing it in both places, so I'm not sure how that's possible

matmarex reopened this task as Open.Feb 12 2016, 5:20 PM

Definitely not fixed.

matmarex claimed this task.Feb 12 2016, 5:20 PM
matmarex raised the priority of this task from Low to High.
matmarex set Security to None.
matmarex added a parent task: T121901: UploadWizard UI performance abysmal when adding many files to upload at once.
matmarex renamed this task from "Maximum number of concurrent upload" isn't respected to "Maximum number of concurrent uploads" (upwiz_maxsimultaneous) isn't respected.Feb 16 2016, 2:13 AM
gerritbot subscribed.Feb 19 2016, 8:04 PM

Change 271819 had a related patch set uploaded (by Bartosz Dziewoński):
uw.controller.Step: Don't allow more than one transition to be in progress

https://gerrit.wikimedia.org/r/271819

gerritbot added a project: Patch-For-Review.Feb 19 2016, 8:04 PM

Change 271820 had a related patch set uploaded (by Bartosz Dziewoński):
Ugly hacks to make file uploads progress look better

https://gerrit.wikimedia.org/r/271820

gerritbot added a comment.Feb 19 2016, 8:40 PM

Change 271819 merged by jenkins-bot:
uw.controller.Step: Don't allow more than one transition to be in progress

https://gerrit.wikimedia.org/r/271819

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 19 2016, 9:00 PM
gerritbot added a comment.Feb 19 2016, 11:59 PM

Change 271934 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "uw.controller.Step: Don't allow more than one transition to be in progress"

https://gerrit.wikimedia.org/r/271934

gerritbot added a comment.Feb 20 2016, 12:01 AM

Change 271934 merged by jenkins-bot:
Revert "uw.controller.Step: Don't allow more than one transition to be in progress"

https://gerrit.wikimedia.org/r/271934

gerritbot added a comment.Feb 20 2016, 12:05 AM

Change 271820 abandoned by Bartosz Dziewoński:
Ugly hacks to make file uploads progress look better

Reason:
Dependency was reverted.

https://gerrit.wikimedia.org/r/271820

matmarex added a comment.Feb 20 2016, 12:06 AM

OK, that didn't work out. I'll give it a think and try again later.

matmarex removed a project: Patch-For-Review.Feb 20 2016, 12:07 AM
gerritbot added a comment.Mar 16 2016, 7:13 PM

Change 277847 had a related patch set uploaded (by Bartosz Dziewoński):
uw.controller.Step: Refactor simultaneous transitions

https://gerrit.wikimedia.org/r/277847

gerritbot added a project: Patch-For-Review.Mar 16 2016, 7:13 PM
gerritbot added a comment.Mar 29 2016, 6:53 PM

Change 277847 merged by jenkins-bot:
uw.controller.Step: Refactor simultaneous transitions

https://gerrit.wikimedia.org/r/277847

gerritbot added a comment.Mar 29 2016, 10:46 PM

Change 280339 had a related patch set uploaded (by Bartosz Dziewoński):
uw.controller.Step: Refactor simultaneous transitions

https://gerrit.wikimedia.org/r/280339

gerritbot added a comment.Mar 29 2016, 11:42 PM

Change 280339 merged by jenkins-bot:
uw.controller.Step: Refactor simultaneous transitions

https://gerrit.wikimedia.org/r/280339

matmarex closed this task as Resolved.Mar 30 2016, 1:51 PM
matmarex edited projects, added MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)), MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)); removed Patch-For-Review, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits