Maniphest T93224

Anonymous user sees Edit & Delete buttons on a public collection
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Jhernandez
	Mar 19 2015, 5:41 PM

Tags

Referenced Files

None

Subscribers

Description

And it shouldn't.

This is caused by passing the wrong user parameter to a view.

Patch soon.

Details

	Subject	Repo	Branch	Lines +/-
	Fix user passed to views\Collection	mediawiki/extensions/Gather	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Jhernandez	T93224 Anonymous user sees Edit & Delete buttons on a public collection
		Resolved		• Jhernandez	T93222 Can't access public collections on beta labs
		Resolved		Jdlrobson	T93254 Add browser test for anon user viewing a collection
		Resolved		• Jhernandez	T92782 Project-wide list of collections
		Resolved		Yurik	T93100 API: Need method to query all public lists
		Resolved		Jdlrobson	T93303 Project wide list of collections should be sorted by last modified date
		Resolved		Yurik	T92690 Collections need a last modified and created field

Event Timeline

• Jhernandez created this task.Mar 19 2015, 5:41 PM

• Jhernandez claimed this task.

• Jhernandez raised the priority of this task from to Unbreak Now!.

• Jhernandez updated the task description. (Show Details)

• Jhernandez added a project: Gather Sprint Diplodocus.

• Jhernandez subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2015, 5:41 PM

• Jhernandez moved this task from In Analysis to In development on the Gather Sprint Diplodocus board.Mar 19 2015, 5:41 PM

Change 197959 had a related patch set uploaded (by Jhernandez):
Fix user passed to views\Collection

https://gerrit.wikimedia.org/r/197959

gerritbot added a project: Patch-For-Review.Mar 19 2015, 5:43 PM

Obviously until T93222 has been merged this will be hard to test 😭

• Jhernandez added a subtask: T93222: Can't access public collections on beta labs.Mar 19 2015, 5:46 PM

Jdlrobson closed subtask T93222: Can't access public collections on beta labs as Resolved.Mar 19 2015, 8:02 PM

Change 197959 merged by jenkins-bot:
Fix user passed to views\Collection

https://gerrit.wikimedia.org/r/197959

Jdlrobson closed this task as Resolved.Mar 19 2015, 8:51 PM

Jdlrobson moved this task from Code review needed to Ready for signoff on the Gather Sprint Diplodocus board.

Jdlrobson subscribed.

Diffusion mentioned this in rMEXTb7ff7189c4f1: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Mar 23 2015, 3:55 PM

• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Diplodocus board.Mar 23 2015, 6:17 PM

Diffusion mentioned this in rEGAT4fc6a89cf998: Fix user passed to views\Collection.Apr 8 2015, 6:17 PM