U10. Flow's TOC on RTL wikis aren't spaced for sidebar
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Negative24
	Mar 21 2015, 10:59 PM

Description

On regular LTR wikis the TOC fills just the horizontal space that posts span. In RTL wikis the TOC is fully right justified without accounting for sidebar space.

Sidebar text also overlays the TOC.

Details

	Subject	Repo	Branch	Lines +/-
	Set both left and width of the fixed nav bar.	mediawiki/extensions/Flow	master	+12 -6

Customize query in gerrit

Related Objects

Mentioned In: rMEXT24d9d70c8618: Updated mediawiki/extensions Project: mediawiki/extensions/Flow…
rEFLWda664511d0d5: Set both left and width of the fixed nav bar.
Mentioned Here: T90378: Flow's small top of the page topic indicator overlaps the side bar in narrow windows on RTL wikis

Event Timeline

Negative24 created this task.Mar 21 2015, 10:59 PM

Negative24 raised the priority of this task from to Needs Triage.

Negative24 updated the task description. (Show Details)

Negative24 added a project: StructuredDiscussions.

Negative24 subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2015, 10:59 PM

Negative24 updated the task description. (Show Details)Mar 21 2015, 11:00 PM

Negative24 set Security to None.

Negative24 renamed this task from Flow's TOC on RTL wikis isn't spaced for sidebar to Flow's TOC on RTL wikis aren't spaced for sidebar.Mar 21 2015, 11:23 PM

Negative24 updated the task description. (Show Details)

Amire80 added a parent task: T2745: [DO NOT USE] RTL/bidirectional issues (tracking) [superseded by #RTL].Mar 21 2015, 11:30 PM

Amire80 updated the task description. (Show Details)

Amire80 added a project: I18n.

@Amire80 You can probably notice that this is from your talk page :)

On which browser does this happen? I couldn't reproduce it on Firefox 36 and Chrome 41.

In T93497#1138699, @Amire80 wrote:

On which browser does this happen? I couldn't reproduce it on Firefox 36 and Chrome 41.

Chrome OS 41 (which is pretty much the same as Chrome 41)

Sorry, I don't have one, and CrossBrowserTesting doesn't support it and I don't see on Chrome on Fedora.

I can reproduce on Chrome 41 on Ubuntu but works on Firefox 36.0.1 on Ubuntu

Ah, reproduced. This does happen on Chrome 41 in Fedora, but not at the top of the page. It happens if you scroll down.

It's similar to T90378, but IIRC that one happened on Firefox, too, so I'm not sure that it's a dupe.

That is the behavior of the TOC. As you scroll past the top fixed TOC it moves to the side to be a sort of header to the infinite scrolling mechanic.

EBernhardson triaged this task as High priority.Mar 23 2015, 5:55 PM

EBernhardson subscribed.

• DannyH added a project: Collaboration-Team-Triage.Mar 23 2015, 10:36 PM

• DannyH moved this task from Untriaged to Team discussion on the Collaboration-Team-Triage board.

Looks like this is probably the .css( 'left' ) in modules/engine/components/board/features/flow-board-navigation.js.

• DannyH edited a custom field.Mar 30 2015, 6:56 PM

• DannyH moved this task from Team discussion to Ready for next sprint on the Collaboration-Team-Triage board.

• DannyH removed a subscriber: • Mattflaschen-WMF.

Let's assign this to Stephane as his first task.

• Mattflaschen-WMF assigned this task to SBisson.Apr 7 2015, 5:38 PM

• DannyH renamed this task from Flow's TOC on RTL wikis aren't spaced for sidebar to U10. Flow's TOC on RTL wikis aren't spaced for sidebar.Apr 8 2015, 11:40 PM

• DannyH added a project: Collaboration-Team-Sprint-U-2015-04-22.

SBisson moved this task from Sprint U - ends April 22 to In Development on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 10 2015, 3:30 PM

Change 203462 had a related patch set uploaded (by Sbisson):
Set right position of fixed nav header.

https://gerrit.wikimedia.org/r/203462

gerritbot added a project: Patch-For-Review.Apr 10 2015, 8:43 PM

SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 10 2015, 8:47 PM

• Mattflaschen-WMF moved this task from Needs Review to Code Review Started on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 10 2015, 11:38 PM

SBisson moved this task from Code Review Started to Needs Review on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 11 2015, 12:48 AM

SBisson moved this task from Needs Review to In Development on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 13 2015, 5:37 PM

SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 13 2015, 8:10 PM

EBernhardson moved this task from Needs Review to Product Review on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 14 2015, 9:58 PM

Change 203462 merged by jenkins-bot:
Set both left and width of the fixed nav bar.