Make a fact for project_id on labs instances
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Andrew
	Mar 23 2015, 10:55 PM

Description

It's going to be ugly, but we're going to need this

Details

	Subject	Repo	Branch	Lines +/-
	replace $::instanceproject with $::labsproject	operations/puppet	production	+9 -9
	Add a labsproject fact that doesn't rely on ldap config.	operations/puppet	production	+23 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Andrew	T87280 Investigate replacing our custom DNS code with Designate
Resolved	Andrew	T93087 Move to a new dns scheme for labs: hostname.projectname.eqiad.wmflabs
Resolved	Andrew	T93684 Make a fact for project_id on labs instances
Resolved	Andrew	T102832 Add project_id to instance metadata during instance creation

Event Timeline

Andrew created this task.Mar 23 2015, 10:55 PM

Andrew raised the priority of this task from to Needs Triage.

Andrew updated the task description. (Show Details)

Andrew subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2015, 10:55 PM

Andrew claimed this task.Mar 23 2015, 10:55 PM

Andrew added a project: Cloud-Services.

Andrew set Security to None.

Andrew added a parent task: T93087: Move to a new dns scheme for labs: hostname.projectname.eqiad.wmflabs.Mar 24 2015, 7:46 PM

Isn't that what ${instanceproject} is?

^ +1

It is, but it comes from ldap. Would be nice if we could get it from metadata instead (but it isn't in there :( )

Andrew triaged this task as Medium priority.May 13 2015, 3:16 PM

Change 220991 had a related patch set uploaded (by Andrew Bogott):
Add a labsproject fact that doesn't rely on ldap config.

https://gerrit.wikimedia.org/r/220991

gerritbot added a project: Patch-For-Review.Jun 25 2015, 10:26 PM

Note that the attached patch will only work once the metadata has been updated for legacy instances.

ok, I've added the project-id metadata setting to every instance.

Andrew closed subtask T102832: Add project_id to instance metadata during instance creation as Resolved.Jun 26 2015, 6:08 PM

Change 220991 merged by Andrew Bogott:
Add a labsproject fact that doesn't rely on ldap config.

https://gerrit.wikimedia.org/r/220991

Andrew mentioned this in rOPUPa3b634fc485a: Add a labsproject fact that doesn't rely on ldap config..Jul 10 2015, 6:33 PM

(This is almost totally done, needs verification before closing)

ok, the fact is in place and works. It depends on the insertion of project-id into metadata by sink_nova_ldap.

In Libery and later, metadata will provide project_id automatically, and we can switch the fact over to use that and strip out the project-id code from sink_nova_ldap.

Some of our code still relies on the ldap $::instanceproject puppet variable, so those refs need to be purged before this bug is closed.

Can we also then get rid of the ldap variable from wikitech puppet groups?

...I think so? But I'm confused by the phrase 'wikitech puppet group'

Change 230652 had a related patch set uploaded (by Andrew Bogott):
replace $::instanceproject with $::labsproject

https://gerrit.wikimedia.org/r/230652

AFAIU operations/puppet's modules/shinken/files/shinkengen, Shinken uses the LDAP data to get a list of instances for a project, so that needs to be updated as well.