Page MenuHomePhabricator
Create Task
Maniphest T93804

edit summary doesn't show label of property when changing claims
Closed, ResolvedPublic
Actions

Description

In recent changes the edit summary for a claim change is now "Created claim: P403: Wilsons River (Q2484535)". P403 should show the label instead.

Details

SubjectRepoBranchLines +/-
Revert "Use EntityIdFormatter in MessageParameterFormatter"mediawiki/extensions/Wikibasemaster+32 -22
Introduce EntityIdPlainLinkFormatter for SummaryFormattermediawiki/extensions/Wikibasemaster+114 -5
Do not pass objects to Summary::addAutoCommentArgsmediawiki/extensions/Wikibasemaster+1 -1
Revert "Use EntityIdFormatter in MessageParameterFormatter"mediawiki/extensions/Wikibasewmf/1.25wmf22+32 -22
Customize query in gerrit

Related Objects

Event Timeline

Lydia_Pintscher created this task.Mar 24 2015, 8:08 PM
Lydia_Pintscher raised the priority of this task from to Unbreak Now!.
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, § Wikidata-Sprint-2015-03-24.
Lydia_Pintscher subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2015, 8:08 PM
matej_suchanek subscribed.Mar 24 2015, 8:22 PM
aude subscribed.Mar 25 2015, 9:10 AM

the cause appears to be https://gerrit.wikimedia.org/r/#/c/192787/, as after reverting that change locally, the summaries work again.

gerritbot subscribed.Mar 25 2015, 9:12 AM

Change 199586 had a related patch set uploaded (by Aude):
Revert "Use EntityIdFormatter in MessageParameterFormatter"

https://gerrit.wikimedia.org/r/199586

gerritbot added a project: Patch-For-Review.Mar 25 2015, 9:12 AM

Change 199587 had a related patch set uploaded (by Aude):
Revert "Use EntityIdFormatter in MessageParameterFormatter"

https://gerrit.wikimedia.org/r/199587

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Mar 25 2015, 9:37 AM
Tobi_WMDE_SW assigned this task to aude.Mar 25 2015, 10:42 AM
Tobi_WMDE_SW set Security to None.
Tobi_WMDE_SW moved this task from Backlog to Doing on the § Wikidata-Sprint-2015-03-24 board.
gerritbot added a comment.Mar 25 2015, 2:50 PM

Change 199587 merged by jenkins-bot:
Revert "Use EntityIdFormatter in MessageParameterFormatter"

https://gerrit.wikimedia.org/r/199587

aude mentioned this in rEWBAf1e9b3864a63: Revert "Use EntityIdFormatter in MessageParameterFormatter".Mar 25 2015, 2:50 PM
hoo lowered the priority of this task from Unbreak Now! to High.Mar 25 2015, 2:55 PM
hoo subscribed.

Fixed on the branch, lowering priority.

hoo merged a task: T93896: double bracket in redirect summary.Mar 25 2015, 3:20 PM
gerritbot added a comment.Mar 25 2015, 4:20 PM

Change 199625 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Do not pass objects to Summary::addAutoCommentArgs

https://gerrit.wikimedia.org/r/199625

gerritbot added a comment.Mar 25 2015, 4:29 PM

Change 199625 merged by jenkins-bot:
Do not pass objects to Summary::addAutoCommentArgs

https://gerrit.wikimedia.org/r/199625

thiemowmde mentioned this in rMEXT8db4cbc39fab: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 25 2015, 4:29 PM
thiemowmde mentioned this in rEWBA27c9ba724618: Do not pass objects to Summary::addAutoCommentArgs.
gerritbot added a comment.Mar 31 2015, 11:07 PM

Change 201062 had a related patch set uploaded (by Hoo man):
Introduce EntityIdPlainLinkFormatter for SummaryFormatter

https://gerrit.wikimedia.org/r/201062

gerritbot added a comment.Apr 1 2015, 11:27 AM

Change 201062 merged by jenkins-bot:
Introduce EntityIdPlainLinkFormatter for SummaryFormatter

https://gerrit.wikimedia.org/r/201062

Diffusion mentioned this in rMEXT9572e4377fa6: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 1 2015, 11:27 AM
hoo mentioned this in rEWBA5a7049b86515: Introduce EntityIdPlainLinkFormatter for SummaryFormatter.Apr 1 2015, 11:28 AM
hoo closed this task as Resolved.Apr 1 2015, 11:28 AM
hoo claimed this task.
hoo removed a project: Patch-For-Review.
hoo moved this task from Doing to Done on the § Wikidata-Sprint-2015-03-24 board.
gerritbot added a comment.Apr 7 2015, 2:25 PM

Change 199586 abandoned by Aude:
Revert "Use EntityIdFormatter in MessageParameterFormatter"

Reason:
we have a proper fix now on master

https://gerrit.wikimedia.org/r/199586

matej_suchanek unsubscribed.Aug 29 2016, 9:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL