Page MenuHomePhabricator

Dispatcher broken on Wikidata
Closed, ResolvedPublic

Description

from terbium: https://phabricator.wikimedia.org/P430 (getting locks and changes are not regarded as relevant)

from my dev wiki where i definitely made relevant changes, but changes are not being regarded as relevant.

23:52:21 Starting loop for 1 passes or unlimited seconds
23:52:21 Picking a client wiki...
23:52:21 Trying testclient
23:52:21 Loaded repo db master
23:52:21 Loaded dispatch changes row for testclient
23:52:21 Loading state for testclient
23:52:21 Trying to get client lock for testclient
23:52:21 Lock name not defined for testclient. Got lock name testclient.WikiBase.dispatchChanges.
23:52:21 Trying to get client master for testclient
23:52:21 Set lock for testclient
23:52:21 Locked client testclient
23:52:21 Locked testclient for site testclient at 6116.
23:52:21 Finding pending changes for testclient
23:52:21 Checking sitelinks to testclient for 1 items.
23:52:21 Retaining changes for 0 relevant items.
23:52:21 Found 0 changes for items with relevant sitelinks.
23:52:21 Got 0 pending changes. Cache hit rate is 0%
23:52:21 Released testclient for site testclient at 6117.
23:52:21 Posted no changes to testclient (nothing to do). Next ID is 6117.
23:52:21 Done, exiting after 1 passes and 0 seconds.

Event Timeline

aude created this task.Mar 24 2015, 11:53 PM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added a project: Wikidata.
aude added a subscriber: aude.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2015, 11:53 PM
aude renamed this task from dispatcher on my dev wiki to Dispatcher broken on Wikidata.Mar 25 2015, 12:07 AM
aude updated the task description. (Show Details)
aude set Security to None.

i meant this to be a paste, but whatever... it's a bug also

hoo triaged this task as Unbreak Now! priority.Mar 25 2015, 12:19 AM
hoo added a subscriber: hoo.
aude closed this task as Resolved.Mar 25 2015, 8:44 AM

we reverted and deployed a couple changes, which fixes the issue for now. we still need to investigate why this happened. the changes were attempting to fix bugs and would be good to indeed have those fixed.

daniel added a subscriber: daniel.Mar 25 2015, 6:55 PM

This fix by @hoo apparently fixes the most pressing issues: https://gerrit.wikimedia.org/r/#/c/199592/

However, T93918 still needs investigation.

aude added a comment.Mar 25 2015, 8:01 PM

Though obviously related, T93918 is not really blocking task since the issue on Wikidata is already "fixed" with revert.

We should definitely still look into T93918 and make sure the issues are fixed on master. Also helpful to have hoo's patch to fix randomness and removing FOR UPDATE.