Zero needs to stop using mobile.templates dependency
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Mar 30 2015, 6:53 PM

Description

This is no longer necessary.
Mobile web would like to drop this but luckily Zero's tests complained. See https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/9755/consoleFull

		Status	Subtype	Assigned	Task
		Resolved		• jhobs	T95361 Zero-dot not warning about possible charge on image link
		Resolved		• jhobs	T94462 Zero needs to stop using mobile.templates dependency

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson subscribed.

Yurik set Security to None.

• DFoy triaged this task as Medium priority.

Mobile web would like to drop this

@Jdlrobson: Is there a task about that which should be blocked by this task?

Test link in description directs to a 404 and no instances of outdated templates can be found within the ZeroBanner repo.

If you grep mobile.templates do you find it anywhere in your resource loader definitions?

Ah, the culprit, thanks. Anything it needs to be replaced with or does removing it suffice given our dependence on MF?

All you need to do is remove it. Template dependencies are taken care of for you now :)

Ping @jhobs can we get this fixed asap, currently this bloats the ResourceLoader startup module unnecessarily. Should be an easy fix...

@Jdlrobson "grep -r mobile.templates ." is finding nothing except a commit message in the git log. Are you sure this wasn't resolved a while ago?