Page MenuHomePhabricator

Remove all the cache related FIXMEs
Closed, ResolvedPublic

Description

We've been bad at cleaning up after ourselves. Please review all of these and remove any that are no longer relevant.

master x ~/git/core/extensions/MobileFrontend $ ag 'FIXME.*cache'
includes/Resources.php
40: FIXME: Remove when cache has cleared
717:
FIXME: Remove after cache is cleared

resources/mobile.editor/init.js
128: FIXME: Clean up selector when cache has cleared.
222:
FIXME: split the selector and cache it

resources/mobile.head/init.js
5: // FIXME: remove #mw-mf-main-menu-button when cache clears

resources/mobile.issues/init.js
99: // FIXME: Cleanup selector when cache has cleared

resources/mobile.mainMenu/icons.less
28:// FIXME: Remove when cache cleared

resources/mobile.mainMenu/MainMenu.js
96: // FIXME: Remove when cache clears https://phabricator.wikimedia.org/T102868

resources/mobile.references/init.js
54: // FIXME: Cleanup selector when cache clears

resources/mobile.startup/init.js
53: FIXME: Clean up when cache clears.
107:
FIXME: Remove this once the cache has cleared. This is tracked by T101721.

resources/mobile.startup/panel.less
5:// FIXME: clean up selectors when cache clears

resources/mobile.startup/Skin.js
50: // FIXME: remove the ID comparison when cache clears

resources/mobile.talk/init.js
41: FIXME: Remove this after cache is cleared
73:
FIXME: Cleanup selector when cache has cleared

resources/mobile.toggling/init.js
4: FIXME: Clean up when cache clears.
319:
FIXME: remove when cache clears

resources/skins.minerva.base.styles/pageactions.less
16:// FIXME: remove the .stable .pre-content selector when cache clears

resources/skins.minerva.base.styles/ui.less
13:// FIXME: Remove content_wrapper when cache clears.
19:// FIXME: Rule resets #content rule and can be removed when cache cleared
24:// FIXME: REMOVE .stable .pre-content.last-modified-bar selector when cache clears

resources/skins.minerva.tablet.styles/common.less
15: FIXME: remove the .stable .pre-content selector when cache clears
21:
FIXME: remove the .stable .pre-content selector when cache clears
113: FIXME: remove when cache clears
122:
FIXME: remove when cache clears

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2015, 6:33 PM

Change 239286 had a related patch set uploaded (by Jdlrobson):
Hygiene: Cleanup cached page FiXMES

https://gerrit.wikimedia.org/r/239286

That was very therapeutic. I would have removed another if not for T94462

(17, -118 lines of code. beautiful.)

Change 239286 merged by jenkins-bot:
Hygiene: Cleanup cached page FiXMES

https://gerrit.wikimedia.org/r/239286

phuedx closed this task as Resolved.Sep 18 2015, 2:26 PM
phuedx added a subscriber: phuedx.

This is a technical task.