Seen in production:
8 Warning: data error in /srv/mediawiki/php-1.25wmf23/extensions/VisualEditor/ApiVisualEditor.php on line 317
Seen in production:
8 Warning: data error in /srv/mediawiki/php-1.25wmf23/extensions/VisualEditor/ApiVisualEditor.php on line 317
The warning is from gzinflate apparently, but that data is supposed to come from EasyDeflate.deflate on the client. I guess someone might just be sending in nonsense.
So if I request this:
api.php?action=visualeditor&html=rawdeflate,testing&page=Main_Page&paction=serializeforcache
We get these errors in hhvm.log:
Apr 3 17:20:15 mw1114: #012Warning: data error in /srv/mediawiki/php-1.25wmf23/extensions/VisualEditor/ApiVisualEditor.php on line 317 Apr 3 17:20:15 mw1114: #012Notice: Undefined index: oldid in /srv/mediawiki/php-1.25wmf23/extensions/VisualEditor/ApiVisualEditor.php on line 562
(Adding an oldid parameter makes the second error not appear.)
Change 201743 had a related patch set uploaded (by Alex Monk):
Check whether html parameter is valid rather than allow warnings to be raised if it is not
Change 201743 merged by jenkins-bot:
Check whether html parameter is valid rather than allow warnings to be raised if it is not
Change 201772 had a related patch set uploaded (by Alex Monk):
Avoid undefined index warning for oldid if it's not set in serializeforcache
Change 201772 merged by jenkins-bot:
Avoid undefined index warning for oldid if it's not set in serializeforcache