Page MenuHomePhabricator

Do not say "< wmf-insecte> Yippee, build fixed!"
Closed, DeclinedPublic

Description

Unknown bot is a bit too verbose. How about, we patch it to emit just one line of robot barf per event. The second message already includes this information, "FIXED in 26 min:".

Related task T64573: Have wmf-insecte use color to make the reading of the scrollback easier

This is stalled until upstream fix it or some of our java developers look at it.


See @hashar comment T95395#1193763
Upstream bug is JENKINS-5031.

Event Timeline

awight raised the priority of this task from to Needs Triage.
awight updated the task description. (Show Details)
awight subscribed.

Also: respond helpfully to a CTCP source request.

/ctcp wmf-insecte source

23:45 [freenode] [ctcp(wmf-insecte)] SOURCE 
23:45 [freenode] -!- wmf-insecte is away: Working:
greg triaged this task as Low priority.Apr 8 2015, 4:23 PM
greg added subscribers: zeljkofilipin, greg.

Since wmf-insecte talks mostly about Browser-Tests I'm associating that project.

@zeljkofilipin do you know where this bot is managed (where it's config is)?

wmf-insecte is the Jenkins IRC client provided by Instant Messaging Plugin.

There is no settings to configure the messages nor there is any to disable the Yippee, build fixed! message. Upstream bug is JENKINS-5031. I commented on it a while back with:

For what it is worth, the messages are defined in: src/main/resources/hudson/plugins/im/build_notify/Messages.properties

SummaryOnlyBuildToChatNotifier.Summary=Project {0} build {1}: {2} in {3}: {4}
SummaryOnlyBuildToChatNotifier.BuildIsFixed=Yippee, build fixed!\n
SummaryOnlyBuildToChatNotifier.StartMessage=Starting build {0} for job {1}

I would love an option to at least disable the BuildIsFixed message. The two other messages should be changeable in the interface, probably globally and on a per job basis. The Summary message shows the job URL which already contains the job name and build number, not much point in repeating them.

The canonical repository is https://github.com/jenkinsci/instant-messaging-plugin , if one find some Java developer to implement customization of messages and the ability to skip BuildIsFixed, I am sure upstream will be happy to merge the code and release a new version which we can then deploy.

The relevant code is in src/main/java/hudson/plugins/im/build_notify/SummaryOnlyBuildToChatNotifier.java`:

Shortened and annotated:

@Override
public String buildCompletionMessage(...) {
    final StringBuilder sb;
    if (BuildHelper.isFix(build)) {
        # It is a fix add the Yippee line
        sb = new StringBuilder(Messages.SummaryOnlyBuildToChatNotifier_BuildIsFixed());
    } else {
        sb = new StringBuilder();
    }

    # Add another line with build informations
    sb.append(Messages.SummaryOnlyBuildToChatNotifier_Summary(
            getProjectName(build), build.getDisplayName(),
            ResultTrend.getResultTrend(build).getID(),
            build.getTimestampString(),
            MessageHelper.getBuildURL(build)));

    return sb.toString();
}

A Java developer will probably find it easy to implement the features :)

greg lowered the priority of this task from Low to Lowest.Apr 9 2015, 3:05 PM
hashar changed the task status from Open to Stalled.May 29 2015, 10:18 AM
hashar edited projects, added Jenkins; removed Release-Engineering-Team.
hashar updated the task description. (Show Details)
hashar moved this task from Next to Waiting on the Browser-Tests-Infrastructure board.
hashar moved this task from Backlog to Reported Upstream on the Upstream board.
hashar moved this task from Backlog to Reported upstream on the Jenkins board.

This is not related to Browser-Tests, removing the project from the task.

Moving it to Continuous-Integration-Infrastructure so the task shows up on at least one of our project boards :-}

My $0.02 USD: WONTFIX and move on.

Fix your tests so they aren't flaky, test locally before uploading, and PROFIT from less log spam both for the failures and the recoveries. Our channels are full of bots that chat away constantly. I really doubt that this one extra message per recovery causes an undue burden on the general irc channel population.

Per Bryan. It is not going to happen unless someone solves it upstream via some java code.