Apply typography, space, and layout styles
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• violetto
	Apr 10 2015, 8:40 AM

Description

Just apply code from here. Mobile-and-tablet-already-friendly.

Details

	Subject	Repo	Branch	Lines +/-
	Update spacing for p and h2	mediawiki/skins/Blueprint	master	+3 -3
	Minor type changes	mediawiki/skins/Blueprint	master	+2 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• violetto	T95661 Apply typography, space, and layout styles
Declined	None	T104673 Remove Blueprint's use of bootstrap
Resolved	None	T107662 Add bootstrap source files with components currently in use at Blueprint

Event Timeline

• violetto created this task.Apr 10 2015, 8:40 AM

• violetto assigned this task to • Prtksxna.

• violetto raised the priority of this task from to Needs Triage.

• violetto updated the task description. (Show Details)

• violetto added projects: Wikimedia Design Style Guide, Design, OOUI.

• violetto added subscribers: Aklapper, • violetto.

• violetto added a subscriber: • werdna.

Change 204484 had a related patch set uploaded (by Prtksxna):
Minor type changes

https://gerrit.wikimedia.org/r/204484

gerritbot added a project: Patch-For-Review.Apr 17 2015, 7:37 AM

Change 204484 merged by jenkins-bot:
Minor type changes

https://gerrit.wikimedia.org/r/204484

• Prtksxna mentioned this in rSKINd096b899c9f7: Updated mediawiki/skins Project: mediawiki/skins/Blueprint….Apr 17 2015, 3:32 PM

@violetto, anything left in this?

@Prtksxna, I fixed some issues. Check em here.

Change 205539 had a related patch set uploaded (by Prtksxna):
Update spacing for p and h2

https://gerrit.wikimedia.org/r/205539

In T95661#1222675, @violetto wrote:

@Prtksxna, I fixed some issues. Check em here.

Submitted a patch with those changes.

• Prtksxna mentioned this in rSBLU881e58982588: Minor type changes.Apr 24 2015, 4:50 PM

matmarex removed a project: OOUI.Apr 26 2015, 3:31 PM

matmarex set Security to None.

@violetto, anything left in this?

Only layout 1 has been applied according to @Prtksxna. Still a work in progress.

Volker_E subscribed.Jul 1 2015, 8:27 PM

@violetto, I thought this task was created for applying those templates to the skin in general, like updating the spacing between headings and paragraphs (see submitted patches), and not for migrating the layouts from Github to the LSG. Sorry about the confusion.

I believe our last conversation about this will help you make the templates yourself. Let me know if you need anything.

The description could be more descriptive. I was hoping we apply the styles from github and be able to use it on the wiki in the future. I'll get to this soon though, no worries.

@Prtksxna, I imagine this task, especially the layout portion will be affected by T104673?

@violetto @Prtksxna No big deal here, (myself) only need to take care about including the base styles from Bootstrap and it's fine.

We have layout templates using Bootstrap classes.

Sure, but using the same classes as Bootstrap or changing to even better names isn't hard. We'll take care.

No worries, was making sure that was captured. Also means I shouldn't go ahead and make more layout templates until T104673 is somewhat completed to reduce complications.

• Prtksxna added a subtask: T104673: Remove Blueprint's use of bootstrap.Jul 4 2015, 2:37 AM

Change 205539 merged by VolkerE:
Update spacing for p and h2

https://gerrit.wikimedia.org/r/205539

• Prtksxna mentioned this in rSBLU75510bf1e17f: Update spacing for p and h2.Aug 27 2015, 9:05 PM

Volker_E mentioned this in rSKINf043a5543a4a: Updated mediawiki/skins Project: mediawiki/skins/Blueprint….Aug 27 2015, 9:05 PM

Volker_E closed this task as Resolved.Sep 12 2015, 3:18 AM

Volker_E moved this task from Backlog to Done on the Wikimedia Design Style Guide board.

WOOhOO

• violetto awarded a token.Sep 12 2015, 7:06 AM

• Prtksxna awarded a token.Sep 18 2015, 7:56 AM

• Prtksxna closed subtask T104673: Remove Blueprint's use of bootstrap as Declined.May 31 2017, 6:11 PM