Page MenuHomePhabricator
Create Task
Maniphest T107662

Add bootstrap source files with components currently in use at Blueprint
Closed, ResolvedPublic
Actions

Description

In order to remove bootstrap from Blueprint, we need to add bootstrap source files with components currently in use at Blueprint and will also update to latest Bootstrap version 3.3.5 from 3.3.4 previously in use.

Details

SubjectRepoBranchLines +/-
Include original Bootstrap source filesmediawiki/skins/Blueprintmaster+4 K -5
Include bootstrap source files and update bootstrap to 3.3.5mediawiki/skins/Blueprintmaster+2 K -23
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• SpageT307 Announcing the Developer Hub prototype release
 Resolved• SpageT299 Release the Developer Hub prototype
 Resolved• SpageT306 Featuring the first three APIs in the Developer Hub
 ResolvedoriT334 Document RCStream in the Developer Hub
 DeclinedNoneT302 API sandboxes for the Developer Hub
 ResolvedNoneT300 Select the three APIs featured at the Developer Hub prototype
 DeclinedNoneT88755 Improve MediaWiki API example behavior
 ResolvedAnomieT89229 API Help should generate [try in ApiSandbox] link to Special:ApiSandbox#action=params from getExamples()
 DeclinedNoneT89318 Replace on-wiki API documentation with Special:ApiHelp transclusion
 OpenNoneT89768 Language support in Special:ApiHelp and its transclusion.
 OpenNoneT90528 Generated API Help doesn't indicate the MediaWiki versions that support a module and parameters.
 Resolved• SpageT89680 Template:ApiEx on mw.org should have a link to "[view in ApiSandbox]".
 DeclinedNoneT335 Document the Content API in the Developer Hub
 ResolvedjeropbrendaT359 Document the Wikidata API in the Developer Hub
 OpenNoneT89863 [Task] Merge on-wiki Wikibase/API documentation into Wikibase apihelp strings.
 DeclinedQgilT303 Setup the Developer Hub prototype
 Resolved• SpageT98164 prototype Data and developer hub with Blueprint skin
 ResolvedQgilT101099 Developer Relations Roadmap
 ResolvedQgilT113030 Developer Relations quarterly review Jul-Sep 2015
 ResolvedQgilT101100 Engineering Community quarterly goals for July-September 2015
 Resolved• SpageT101441 Goal: Integrate the new Web APIs hub with mediawiki.org
 Resolved• SpageT305 Developer Hub homepage
 Resolved• SpageT301 Define the look&feel of the Developer Hub
 DeclinedNoneT93062 Define the navigation elements of the Web APIs hub
 DeclinedNoneT317 "Terms of Use" must be prominently featured in the Developer Hub
 Resolved• SpageT92941 Define personas for dev.wikimedia.org
 Resolved• SpageT92945 Reflect in dev.wikimedia.org what Wikimedia offers to developers
 DeclinedNoneT93610 Put WikimediaUI Style Guide on mediawiki.org
 DeclinedNoneT93613 Deploy Blueprint on mediawiki.org as optional and experimental skin
 InvalidNoneT110844 User menu problem in blueprint skin
 Resolved• violettoT95661 Apply typography, space, and layout styles
 DeclinedNoneT111134 Navbar's Dropdown Menu `.navbar-right > .dropdown-menu` should align to LSG
 DeclinedNoneT103730 Fix Blueprint top bar. Currently obscuring h1#firstHeading by wrapping onto the second line.
 DeclinedNoneT104680 Make Blueprint responsive
 DeclinedNoneT104673 Remove Blueprint's use of bootstrap
 ResolvedNoneT107662 Add bootstrap source files with components currently in use at Blueprint

Event Timeline

Volker_E created this task.Aug 1 2015, 3:58 PM
Volker_E raised the priority of this task from to High.
Volker_E updated the task description. (Show Details)
Volker_E added a project: Blueprint.
Volker_E updated the task description. (Show Details)
Volker_E set Security to None.
Volker_E added subscribers: • Prtksxna, Volker_E, • Spage, Aklapper.
gerritbot subscribed.Aug 1 2015, 4:24 PM

Change 226517 had a related patch set uploaded (by VolkerE):
Include bootstrap source files and update bootstrap to 3.3.5

https://gerrit.wikimedia.org/r/226517

gerritbot added a project: Patch-For-Review.Aug 1 2015, 4:24 PM
Volker_E moved this task from Backlog to Needs Review / Feedback on the Blueprint board.Aug 2 2015, 10:40 PM
gerritbot added a comment.Aug 11 2015, 4:41 PM

Change 230410 had a related patch set uploaded (by Paladox):
Improvements to Blueprint skin

https://gerrit.wikimedia.org/r/230410

gerritbot added a comment.Aug 29 2015, 7:02 PM

Change 226517 merged by VolkerE:
Include bootstrap source files and update bootstrap to 3.3.5

https://gerrit.wikimedia.org/r/226517

Paladox mentioned this in rSKINcaa60c0ce549: Updated mediawiki/skins Project: mediawiki/skins/Blueprint….Aug 29 2015, 7:02 PM
Paladox mentioned this in rSBLU74cf295d710d: Include bootstrap source files and update bootstrap to 3.3.5.Aug 29 2015, 7:05 PM
Paladox subscribed.Aug 30 2015, 5:40 PM

I think this can be closed now.

Aklapper added a comment.Sep 13 2015, 9:09 PM

@Volker_E: Anything left to do here?

Volker_E added a comment.Sep 13 2015, 10:57 PM

@Aklapper Yes, unfortunately. @Paladox has updated the files and we are now including the unminified Bootstrap CSS and JS files, but the CSS is a rendered Less file. A thing to criticize Bootstrap is, that by relying on getbootstrap service only, it's not possible to get to the original, modules Less files, so I have to look into and search for the corresponding ones in the Git repo which are source for our currently in-use, rendered CSS one.
Hope to get this done within the next days.

Volker_E added a parent task: T103730: Fix Blueprint top bar. Currently obscuring h1#firstHeading by wrapping onto the second line..Sep 14 2015, 5:45 AM
Paladox added a comment.Sep 14 2015, 6:24 AM

The resource loader minifys it on load. So there was no point in including a min file.

Volker_E added a comment.Sep 14 2015, 11:00 PM

@Paladox agreed, you did the right thing. My statement was just that there's even more to do at this task.

Paladox added a comment.EditedSep 15 2015, 6:28 AM

But it shoulden really make it more of a task because all I did was change the min file to a full file and updated it to latest version.

gerritbot added a comment.Nov 8 2015, 10:13 AM

Change 251803 had a related patch set uploaded (by VolkerE):
Include original Bootstrap source files

https://gerrit.wikimedia.org/r/251803

gerritbot added a comment.Nov 8 2015, 10:18 AM

Change 251803 merged by jenkins-bot:
Include original Bootstrap source files

https://gerrit.wikimedia.org/r/251803

Volker_E closed this task as Resolved.Nov 8 2015, 10:19 AM
Volker_E moved this task from Needs Review / Feedback to Done on the Blueprint board.
Volker_E removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits