Migrate the oauth patches into our phabricator/extensions repository to avoid manually rebasing two patches every time we pull from upstream.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• mmodell
	Apr 19 2015, 2:34 PM

Description

Since the oauth patch hasn't made much progress upstream in recent months, I'm importing the oauth code into our phabricator/extensions repository (rPHEX)

rPHEX10a404e97697 is the patch as it existed for the past several months. The commit message for that commit explains my plan for migrating the patch out of the phab repo so that we don't have to continue rebasing a patch against upstream changes.

https://gerrit.wikimedia.org/r/#/c/205090/ is the fix for a couple of bugs that I discovered in the process of moving the patch and testing it in preparation for the upcoming phabricator upgrade.

Related Objects
Search...

Status	Assigned	Task
Declined	• mmodell	T368 Upstream mediawiki oauth provider for Phabricator
Resolved	• mmodell	T96510 Migrate the oauth patches into our phabricator/extensions repository to avoid manually rebasing two patches every time we pull from upstream.
Resolved	• mmodell	T89830 Next Phabricator upgrade on 2015-05-06
Resolved	• KLans_WMF	T95469 Test phabricator sprint extension updates
Resolved	• mmodell	T96618 just in case: set up a new oauth consumer on mediawiki.org that has oauth callback url checkbox enabled

Event Timeline

• mmodell created this task.Apr 19 2015, 2:34 PM

• mmodell claimed this task.

• mmodell raised the priority of this task from to High.

• mmodell updated the task description. (Show Details)

• mmodell added projects: Patch-For-Review, Phabricator, Release-Engineering-Team.

• mmodell added a parent task: T89830: Next Phabricator upgrade on 2015-05-06.

• mmodell removed a parent task: T89830: Next Phabricator upgrade on 2015-05-06.

• mmodell added subscribers: Aklapper, • mmodell, • chasemp.

• mmodell added a subtask: T89830: Next Phabricator upgrade on 2015-05-06.Apr 19 2015, 2:36 PM

The only work that still needs to be done on this is to create symlinks from /srv/phab/phabricator/src/extensions/ pointing to the two new files added in https://gerrit.wikimedia.org/r/#/c/205090/

Liuxinyu970226 subscribed.Apr 20 2015, 1:11 AM

• mmodell closed subtask T96618: just in case: set up a new oauth consumer on mediawiki.org that has oauth callback url checkbox enabled as Resolved.Apr 21 2015, 9:53 PM