Page MenuHomePhabricator

Tech debt: Clean up "minerva" folder theme in VE-mw
Closed, ResolvedPublic1 Estimated Story Points

Description

There's a minerva theme in ve-mw/ui/themes/minerva. Right now it holds some styling for template stuff (ve.ui.MWParameterPage.css) and MobileWindowManager.css which had mobile rules and were fixed up to correct a few mobile bugs. Since minerva isn't exactly a theme (?) it should probably be renamed -- and some of the rules in it might be duplicates of non-mobile VE.

The entire thing should be cleaned up, preserving the mobile rules in a cleaner way.

Event Timeline

Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo added subscribers: Mooeypoo, Aklapper.
Jdforrester-WMF moved this task from To Triage to Planned Maintenance on the VisualEditor board.
Jdforrester-WMF set Security to None.

T96703: Tech debt: Move the "minerva" mobile css files to VisualEditor core moves the stuff for the mobile window manager, but that leaves ve.ui.MWParameterPage.css.

• Deskana lowered the priority of this task from Medium to Low.Aug 31 2018, 10:45 AM
• matmarex subscribed.

I found this task while looking for easy tasks for GCI students (story points = 1), but the solution wasn't obvious, and by investigating it I basically solved the whole task, so I'll just submit a patch instead of making someone else rename a bunch of files.

Change 469158 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Move styles that are not theme-wide out of themes/

https://gerrit.wikimedia.org/r/469158

Change 469158 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Move styles that are not theme-wide out of themes/

https://gerrit.wikimedia.org/r/469158