Page MenuHomePhabricator
Create Task
Maniphest T96703

Tech debt: Move the "minerva" mobile css files to VisualEditor core
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

MobileWindowManager.css is in ve-mw/ui/themes/minerva/ folder. It should probably go into VE core, wherever VE holds its mobile-specific files.

Details

SubjectRepoBranchLines +/-
Remove Minerva MobileWindowManager.cssmediawiki/extensions/VisualEditormaster+3 -25
MobileWindowManager: Bring in styles from MW-MinervaVisualEditor/VisualEditormaster+15 -1
Customize query in gerrit

Related Objects

Event Timeline

Mooeypoo created this task.Apr 21 2015, 4:32 PM
Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo added a project: VisualEditor-MediaWiki-Mobile.
Mooeypoo subscribed.
Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 21 2015, 4:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper added a project: Technical-Debt.Apr 21 2015, 6:28 PM
nshahquinn-wmf triaged this task as Medium priority.May 19 2015, 4:15 PM
nshahquinn-wmf set Security to None.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Jun 18 2015, 1:06 AM
Jdforrester-WMF moved this task from Freezer to Epics on the VisualEditor board.Jul 31 2015, 11:27 PM
Jdforrester-WMF renamed this task from Tech debt: Move the mobile css files to core to Tech debt: Move the "minerva" mobile css files to core.Aug 3 2015, 2:22 AM
Jdforrester-WMF edited a custom field.
Legoktm renamed this task from Tech debt: Move the "minerva" mobile css files to core to Tech debt: Move the "minerva" mobile css files to VisualEditor core.Aug 3 2015, 2:26 AM
gerritbot subscribed.Aug 10 2015, 2:15 PM

Change 230544 had a related patch set uploaded (by Esanders):
Bring in MobileWindowManagers styles from MW-Minerva

https://gerrit.wikimedia.org/r/230544

gerritbot added a project: Patch-For-Review.Aug 10 2015, 2:15 PM
gerritbot added a comment.Aug 10 2015, 2:21 PM

Change 230548 had a related patch set uploaded (by Esanders):
Remove Minerva MobileWindowManager.css

https://gerrit.wikimedia.org/r/230548

Jdforrester-WMF mentioned this in T96704: Tech debt: Clean up "minerva" folder theme in VE-mw.Aug 10 2015, 3:21 PM
gerritbot added a comment.Aug 10 2015, 3:26 PM

Change 230544 merged by jenkins-bot:
MobileWindowManager: Bring in styles from MW-Minerva

https://gerrit.wikimedia.org/r/230544

Jdforrester-WMF mentioned this in rGVED9f92a0f9ec68: MobileWindowManager: Bring in styles from MW-Minerva.Aug 10 2015, 3:26 PM
gerritbot added a comment.Aug 10 2015, 3:57 PM

Change 230548 merged by jenkins-bot:
Remove Minerva MobileWindowManager.css

https://gerrit.wikimedia.org/r/230548

Jdforrester-WMF mentioned this in rEVEDd9ff657c514c: Remove Minerva MobileWindowManager.css.Aug 10 2015, 3:57 PM
• Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 10 2015, 4:00 PM
Jdforrester-WMF closed this task as Resolved.Aug 10 2015, 4:02 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.Sep 1 2015, 10:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL