Page MenuHomePhabricator
Create Task
Maniphest T97605

In iOS 8 Safari, trying to scroll in the WikiText editor results in content disappearing
Closed, ResolvedPublic
Actions

Description

When I try to scroll within the WikiText editor in iOS 8, all the content disappears. Tested in iOS 8.0 and 8.3 on English Wikipedia and current master.

Details

SubjectRepoBranchLines +/-
Fixing scrolling in the editor in Mobile Safarimediawiki/extensions/MobileFrontendwmf/1.26wmf3+5 -9
Fixing scrolling in the editor in Mobile Safarimediawiki/extensions/MobileFrontendwmf/1.26wmf4+5 -9
Fixing scrolling in the editor in Mobile Safarimediawiki/extensions/MobileFrontendmaster+5 -9
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.Apr 29 2015, 11:37 PM
kaldari raised the priority of this task from to Unbreak Now!.
kaldari updated the task description. (Show Details)
kaldari added a project: Web-Team-Backlog.
kaldari subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2015, 11:37 PM
kaldari added a project: Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story.Apr 30 2015, 12:15 AM
kaldari set Security to None.
kaldari added a comment.Apr 30 2015, 12:28 AM

It looks like https://gerrit.wikimedia.org/r/#/c/203095/ fixed T95465 (which affected all iOS versions), but it introduced this bug (judging from git bisect).

kaldari claimed this task.Apr 30 2015, 12:47 AM
kaldari moved this task from Needs Analysis to Doing on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.
gerritbot subscribed.Apr 30 2015, 1:53 AM

Change 207705 had a related patch set uploaded (by Kaldari):
Fixing scrolling in the editor in Mobile Safari

https://gerrit.wikimedia.org/r/207705

gerritbot added a project: Patch-For-Review.Apr 30 2015, 1:53 AM
kaldari added a comment.Apr 30 2015, 1:56 AM

Found the root cause, which was pretty trivial to fix. Also removed the previous work-around while I was at it, since this seemed to cause a different bug (T97605).

kaldari moved this task from Doing to Code Review on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.Apr 30 2015, 1:57 AM
gerritbot added a comment.Apr 30 2015, 1:41 PM

Change 207705 merged by jenkins-bot:
Fixing scrolling in the editor in Mobile Safari

https://gerrit.wikimedia.org/r/207705

Diffusion mentioned this in rMEXTb41aa54639a3: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Apr 30 2015, 1:43 PM
phuedx mentioned this in rEMFRba90db37792e: Fixing scrolling in the editor in Mobile Safari.Apr 30 2015, 1:43 PM
phuedx closed this task as Resolved.Apr 30 2015, 3:07 PM
phuedx moved this task from Code Review to Done on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.
phuedx removed a project: Patch-For-Review.
phuedx subscribed.
gerritbot added a comment.Apr 30 2015, 5:43 PM

Change 207850 had a related patch set uploaded (by Kaldari):
Fixing scrolling in the editor in Mobile Safari

https://gerrit.wikimedia.org/r/207850

gerritbot added a project: Patch-For-Review.Apr 30 2015, 5:43 PM

Change 207852 had a related patch set uploaded (by Kaldari):
Fixing scrolling in the editor in Mobile Safari

https://gerrit.wikimedia.org/r/207852

gerritbot added a comment.Apr 30 2015, 11:09 PM

Change 207852 merged by jenkins-bot:
Fixing scrolling in the editor in Mobile Safari

https://gerrit.wikimedia.org/r/207852

gerritbot added a comment.Apr 30 2015, 11:09 PM

Change 207850 merged by jenkins-bot:
Fixing scrolling in the editor in Mobile Safari

https://gerrit.wikimedia.org/r/207850

kaldari mentioned this in rEMFR34647ed45a53: Fixing scrolling in the editor in Mobile Safari.Apr 30 2015, 11:10 PM
kaldari mentioned this in rEMFR7c104b5947ef: Fixing scrolling in the editor in Mobile Safari.
• Phabricator_maintenance moved this task from Incoming to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:35 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMar 7 2018, 1:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL