Page MenuHomePhabricator
Create Task
Maniphest T97623

Allow users of SpecialStatsAddExtra hook to provide row labels that are not i18n keys
Closed, ResolvedPublic
Actions

Description

The SpecialStatsAddExtra hook is great, but some things that should go in the left-hand column (row label) are not possible in the current form. For example, when page counters were removed (T74420: Turn hit counters (which were removed in 1.25) into an extension) the top-10 viewed pages was taken away from Special:Statistics.

Because it uses i18n keys without arguments for the content of the left-hand column, it is no longer possible to link to each page.

Details

SubjectRepoBranchLines +/-
SpecialStatsAddExtra: Format column label with msgmediawiki/coremaster+16 -5
SpecialStatsAddExtra: Format column label with msgmediawiki/coreREL1_25+16 -5
Customize query in gerrit

Related Objects

Event Timeline

MarkAHershberger created this task.Apr 30 2015, 2:37 AM
MarkAHershberger raised the priority of this task from to Needs Triage.
MarkAHershberger updated the task description. (Show Details)
MarkAHershberger added a project: MediaWiki-extensions-General.
MarkAHershberger added subscribers: MarkAHershberger, siebrand.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2015, 2:37 AM
gerritbot subscribed.Apr 30 2015, 2:45 AM

Change 207721 had a related patch set uploaded (by MarkAHershberger):
Hook users can specify both columns in detail

https://gerrit.wikimedia.org/r/207721

gerritbot added a project: Patch-For-Review.Apr 30 2015, 2:45 AM

Change 207722 had a related patch set uploaded (by MarkAHershberger):
Hook users can specify both columns in detail

https://gerrit.wikimedia.org/r/207722

MarkAHershberger set Security to None.Apr 30 2015, 2:47 AM
MarkAHershberger added a subscriber: • demon.
Aklapper triaged this task as Medium priority.Apr 30 2015, 11:29 AM
Aklapper edited projects, added MediaWiki-General, MW-1.25-release; removed MediaWiki-extensions-General.
gerritbot added a comment.May 1 2015, 5:40 PM

Change 207721 abandoned by MarkAHershberger:
Hook users can specify both columns in detail

https://gerrit.wikimedia.org/r/207721

Prod subscribed.May 4 2015, 12:24 AM
MarkAHershberger mentioned this in rMW1948c00f06d7: SpecialStatsAddExtra: Format column label with msg.May 20 2015, 2:18 PM
gerritbot added a comment.May 23 2015, 1:23 PM

Change 207722 merged by jenkins-bot:
SpecialStatsAddExtra: Format column label with msg

https://gerrit.wikimedia.org/r/207722

Legoktm mentioned this in rMW0f19ee9d85aa: SpecialStatsAddExtra: Format column label with msg.May 23 2015, 1:24 PM
gerritbot added a comment.May 23 2015, 1:30 PM

Change 207721 restored by Chad:
Hook users can specify both columns in detail

Reason:
Restoring to push latest patch version

https://gerrit.wikimedia.org/r/207721

gerritbot added a comment.May 23 2015, 1:33 PM

Change 207721 had a related patch set uploaded (by Chad):
SpecialStatsAddExtra: Format column label with msg

https://gerrit.wikimedia.org/r/207721

gerritbot added a comment.May 23 2015, 1:42 PM

Change 207721 merged by jenkins-bot:
SpecialStatsAddExtra: Format column label with msg

https://gerrit.wikimedia.org/r/207721

• demon mentioned this in rMWb04b2354a294: SpecialStatsAddExtra: Format column label with msg.May 23 2015, 1:42 PM
• demon closed this task as Resolved.May 23 2015, 1:51 PM
• demon claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits