Page MenuHomePhabricator
Create Task
Maniphest T97646

[Regression wmf3] Action "switch to source editing" does not activate
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

2Снимок.PNG (332×589 px, 21 KB)

action "switch to source editing" is not active - the text is gray and can not be pressed
but if open VE, add some text, and press tab Edit source (which is near View history), then switching window (to keep or discard the changes) will seem normal

Details

SubjectRepoBranchLines +/-
Make sure switch to source editing button does not get disabledmediawiki/extensions/VisualEditorwmf/1.26wmf5+1 -0
Make sure switch to source editing button does not get disabledmediawiki/extensions/VisualEditorwmf/1.26wmf4+1 -0
Make sure switch to source editing button does not get disabledmediawiki/extensions/VisualEditormaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Sunpriat created this task.Apr 30 2015, 2:17 PM
Sunpriat raised the priority of this task from to Needs Triage.
Sunpriat updated the task description. (Show Details)
Sunpriat added a project: VisualEditor.
Sunpriat subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2015, 2:17 PM
Krenair added subscribers: Krenair, Mooeypoo, Catrope.Apr 30 2015, 2:39 PM

https://gerrit.wikimedia.org/r/#/c/204934/ ?

Krenair added a project: VisualEditor-MediaWiki.Apr 30 2015, 2:39 PM
Jdforrester-WMF renamed this task from VE: action "switch to source editing" is not active to [Regression wmf3] Action "switch to source editing" does not activate.Apr 30 2015, 6:24 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.May 8 2015, 1:42 AM
matmarex raised the priority of this task from Medium to High.May 8 2015, 11:05 PM
matmarex merged a task: T98595: editModeSource widget is currently disabled.
matmarex added subscribers: • MSchottlender-WMF, matmarex, Jdforrester-WMF, Dereckson.

Bumping priority, this is making us look bad, since it looks as if we intentionally disabled this feature :)

Krenair claimed this task.May 8 2015, 11:24 PM
gerritbot subscribed.May 8 2015, 11:25 PM

Change 209824 had a related patch set uploaded (by Alex Monk):
Make sure switch to source editing button does not get disabled

https://gerrit.wikimedia.org/r/209824

gerritbot added a project: Patch-For-Review.May 8 2015, 11:25 PM
gerritbot added a comment.May 8 2015, 11:32 PM

Change 209824 merged by jenkins-bot:
Make sure switch to source editing button does not get disabled

https://gerrit.wikimedia.org/r/209824

Krenair mentioned this in rEVEDdb036ddd8da4: Make sure switch to source editing button does not get disabled.May 8 2015, 11:32 PM
Jdforrester-WMF closed this task as Resolved.May 8 2015, 11:34 PM
Jdforrester-WMF edited projects, added VisualEditor 2014/15 Q4 blockers, WMF-deploy-2015-05-13_(1.26wmf6); removed Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
gerritbot added a comment.May 9 2015, 8:18 PM

Change 209947 had a related patch set uploaded (by Alex Monk):
Make sure switch to source editing button does not get disabled

https://gerrit.wikimedia.org/r/209947

gerritbot added a project: Patch-For-Review.May 9 2015, 8:18 PM

Change 209948 had a related patch set uploaded (by Alex Monk):
Make sure switch to source editing button does not get disabled

https://gerrit.wikimedia.org/r/209948

gerritbot added a comment.May 9 2015, 8:21 PM

Change 209948 merged by jenkins-bot:
Make sure switch to source editing button does not get disabled

https://gerrit.wikimedia.org/r/209948

gerritbot added a comment.May 9 2015, 8:22 PM

Change 209947 merged by jenkins-bot:
Make sure switch to source editing button does not get disabled

https://gerrit.wikimedia.org/r/209947

Krenair mentioned this in rEVEDd28ccaf0d1fd: Make sure switch to source editing button does not get disabled.May 9 2015, 8:22 PM
Krenair mentioned this in rEVED5624a03bf7d1: Make sure switch to source editing button does not get disabled.
Jdforrester-WMF removed a project: Patch-For-Review.Jun 3 2015, 5:47 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to FY 18-19 Q3/Q4 on the VisualEditor board.Jun 17 2015, 11:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits