Options: 'Cancel' button does not cancel entered values and applies 'Show the Table of Contents' immediately(?)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Etonkovidova
	Apr 30 2015, 6:42 PM

Description

Found in betalabs, test2, and production.

Open a page in VE - click on the sandwich button - Options.
Go to 'Page settings' or to 'Advanced settings' - modify previously saved settings there: check/uncheck boxes, enter something into available fields etc.

click 'Cancel' - the Options box will be closed. When you re-open it - the settings that you've just entered and Cancel still are displayed.

The most visible case - click on one of the tabs for 'Show the Table of Contents' - click on 'Cancel', but the action takes place anyway.

"Canceled" settings will be applied upon saving the page.

Note: other Cancel buttons(template, media etc) - they work as expected.

Details

	Subject	Repo	Branch	Lines +/-
	Unbreak meta dialog cancel button	mediawiki/extensions/VisualEditor	master	+14 -1

Customize query in gerrit

Related Objects

Mentioned In: rEVED871a0a288f8f: Unbreak meta dialog cancel button

Event Timeline

Etonkovidova created this task.Apr 30 2015, 6:42 PM

Etonkovidova raised the priority of this task from to Needs Triage.

Etonkovidova updated the task description. (Show Details)

Etonkovidova added a project: VisualEditor.

Etonkovidova subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2015, 6:42 PM

Jdforrester-WMF renamed this task from Options: 'Cancel' button does not cancel entered values to Options: 'Cancel' button does not cancel entered values and applies 'Show the Table of Contents' immediately(?).Apr 30 2015, 6:43 PM

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF added a project: VisualEditor-MediaWiki.

Jdforrester-WMF set Security to None.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.May 8 2015, 1:42 AM

Jdforrester-WMF merged a task: T106467: VE incorrectly keeps settings even if the page settings dialog box is closed via cancel instead of apply.Jul 22 2015, 4:01 PM

Jdforrester-WMF added a subscriber: MarkAHershberger.

Krenair raised the priority of this task from Medium to High.Jul 30 2015, 11:14 PM

Krenair subscribed.

Change 228174 had a related patch set uploaded (by Alex Monk):
Unbreak meta dialog cancel button

https://gerrit.wikimedia.org/r/228174

gerritbot added a project: Patch-For-Review.Jul 30 2015, 11:27 PM

Krenair claimed this task.Jul 30 2015, 11:32 PM