Page MenuHomePhabricator
Create Task
Maniphest T97744

Rendering messed up on nojs reply page
Closed, ResolvedPublic
Actions

Description

Same rendering fail as T97624: First topic of new page not rendered properly due to missing mw-content-ltr/rtl, but the action=reply in the URL prevents the fix for that bug from working :(

Details

SubjectRepoBranchLines +/-
Follow-up f7015eb5e4: add mw-content-{ltr,rtl} for all non-view actionsmediawiki/extensions/Flowmaster+2 -2
Hack around action=reply not getting mw-content-{ltr,rtl}mediawiki/extensions/Flowmaster+8 -1
Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionallymediawiki/coremaster+5 -9
Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionallymediawiki/corewmf/1.26wmf4+5 -9
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.May 1 2015, 1:00 AM
Catrope raised the priority of this task from to Unbreak Now!.
Catrope updated the task description. (Show Details)
Catrope added a project: StructuredDiscussions.
Catrope subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 1 2015, 1:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.May 1 2015, 10:06 PM

Change 208282 had a related patch set uploaded (by Catrope):
Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally

https://gerrit.wikimedia.org/r/208282

gerritbot added a project: Patch-For-Review.May 1 2015, 10:06 PM
Catrope claimed this task.May 1 2015, 10:07 PM
Catrope added a project: Collaboration-Team-Sprint-A-2015-05-06.
Catrope set Security to None.
Catrope moved this task from Sprint A - ends May 6 to Needs Review on the Collaboration-Team-Sprint-A-2015-05-06 board.
gerritbot added a comment.May 2 2015, 1:55 AM

Change 208282 merged by jenkins-bot:
Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally

https://gerrit.wikimedia.org/r/208282

Catrope mentioned this in rMW143c81451eb8: Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally.May 2 2015, 1:55 AM
gerritbot added a comment.May 2 2015, 2:35 AM

Change 208332 had a related patch set uploaded (by Catrope):
Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally

https://gerrit.wikimedia.org/r/208332

matthiasmullie moved this task from Needs Review to QA Review on the Collaboration-Team-Sprint-A-2015-05-06 board.May 4 2015, 12:16 PM
Etonkovidova moved this task from QA Review to Done on the Collaboration-Team-Sprint-A-2015-05-06 board.May 4 2015, 9:09 PM
• DannyH closed this task as Resolved.May 4 2015, 10:38 PM
• DannyH subscribed.
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.May 4 2015, 10:48 PM
gerritbot added a comment.May 4 2015, 11:09 PM

Change 208332 merged by jenkins-bot:
Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally

https://gerrit.wikimedia.org/r/208332

Catrope mentioned this in rMW73c9d0ad5eae: Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally.May 4 2015, 11:09 PM
Nikerabbit subscribed.May 13 2015, 8:06 AM

This caused regression at least in Translate. See I0c0466023bc3b for example.

gerritbot added a comment.May 15 2015, 5:23 PM

Change 211141 had a related patch set uploaded (by Catrope):
Hack around action=reply not getting mw-content-{ltr,rtl}

https://gerrit.wikimedia.org/r/211141

gerritbot added a comment.May 15 2015, 6:06 PM

Change 211141 merged by jenkins-bot:
Hack around action=reply not getting mw-content-{ltr,rtl}

https://gerrit.wikimedia.org/r/211141

Catrope mentioned this in rMEXTdd8cfbd44fbf: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….May 15 2015, 6:07 PM
Catrope mentioned this in rEFLWf7015eb5e481: Hack around action=reply not getting mw-content-{ltr,rtl}.
gerritbot added a comment.May 29 2015, 9:15 PM

Change 214767 had a related patch set uploaded (by Catrope):
Follow-up f7015eb5e4: add mw-content-{ltr,rtl} for all non-view actions

https://gerrit.wikimedia.org/r/214767

Catrope reopened this task as Open.May 29 2015, 9:15 PM

It wasn't just action=reply, it was also action=edit-header, edit-topic, edit-post and probably many more.

Catrope added a project: Collaboration-Team-Sprint-B-2015-05-20.May 29 2015, 9:15 PM
Catrope moved this task from Sprint B - ends May 27 to Needs Review on the Collaboration-Team-Sprint-B-2015-05-20 board.
matthiasmullie moved this task from Needs Review to QA Review on the Collaboration-Team-Sprint-B-2015-05-20 board.Jun 1 2015, 2:40 PM
gerritbot added a comment.Jun 1 2015, 4:08 PM

Change 214767 merged by Matthias Mullie:
Follow-up f7015eb5e4: add mw-content-{ltr,rtl} for all non-view actions

https://gerrit.wikimedia.org/r/214767

Catrope mentioned this in rMEXTad88e2683c7d: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Jun 1 2015, 4:08 PM
matthiasmullie mentioned this in rEFLWe801322aa726: Follow-up f7015eb5e4: add mw-content-{ltr,rtl} for all non-view actions.Jun 1 2015, 4:08 PM
• DannyH closed this task as Resolved.Jun 2 2015, 4:25 PM
• DannyH moved this task from QA Review to Done on the Collaboration-Team-Sprint-B-2015-05-20 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL