Page MenuHomePhabricator

improve RELEASE-NOTES-1.25 for formatversion=2 change
Closed, ResolvedPublic

Description

As of 2015-05-04 it says

Many modules have changed result data formats. While this shouldn't affect clients not using the experimental formatversion=2015, code using ApiResult::getResultData() and not using ApiResult::transformForBC() may need updating.

but it's formatversion=2 and there's no transformForBC() instead there are META_TYPEs BCarray, BCkvp, and META_BC_BOOLS. Also e.g. extensions/EventLogging/includes/ApiJsonSchema.php doesn't use getResultData() (it calls getResult() and $result->addValue() ), yet it needed updating with META_BC_BOOLS to fix breakage.

@Anomie cautions this should still be flagged experimental in 1.25 since there may be extra changes if results get improved.

https://www.mediawiki.org/wiki/MediaWiki_1.25#API_changes will also need work.

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

Spage raised the priority of this task from to Normal.
Spage updated the task description. (Show Details)

Change 208956 had a related patch set uploaded (by Anomie):
Improve RELEASE-NOTES for recent API change

https://gerrit.wikimedia.org/r/208956

Anomie moved this task from Unsorted to Needs Review on the MediaWiki-API board.May 5 2015, 2:00 PM

Change 208956 merged by jenkins-bot:
Improve RELEASE-NOTES for recent API change

https://gerrit.wikimedia.org/r/208956

Change 211275 had a related patch set uploaded (by Legoktm):
Improve RELEASE-NOTES for recent API change

https://gerrit.wikimedia.org/r/211275

Change 211275 merged by jenkins-bot:
Improve RELEASE-NOTES for recent API change

https://gerrit.wikimedia.org/r/211275

Legoktm closed this task as Resolved.May 15 2015, 8:21 PM
Legoktm claimed this task.
Legoktm reassigned this task from Legoktm to Anomie.
Legoktm set Security to None.