Page MenuHomePhabricator
Create Task
Maniphest T98759

No logout button shown in stable
Closed, ResolvedPublic
Actions

Description

Screen Shot 2015-05-11 at 6.30.46 PM.png (648×374 px, 59 KB)

Is this intentional?

Details

SubjectRepoBranchLines +/-
Support for cached menu data in HTMLmediawiki/extensions/MobileFrontendwmf/1.26wmf6+42 -4
Support for cached menu data in HTMLmediawiki/extensions/MobileFrontendmaster+42 -4
Show the logout linkmediawiki/extensions/MobileFrontendmaster+19 -5
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.May 11 2015, 5:30 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson moved this task to Incoming on the Web-Team-Backlog board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2015, 5:30 PM
Jdlrobson added a subscriber: phuedx.May 11 2015, 10:28 PM

@phuedx ^

Jdlrobson renamed this task from No logout button shown to No logout button shown in stable.May 11 2015, 10:28 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson set Security to None.
Jdlrobson updated the task description. (Show Details)
Florian subscribed.May 12 2015, 5:44 AM

Same for me in stable, beta and alpha :/

phuedx added a comment.May 12 2015, 10:33 AM

This is caused by SkinMinerva#flattenLinkArray not dealing with the input having more than one link, which the result of #getPersonalTools does.

phuedx claimed this task.May 12 2015, 10:36 AM
phuedx added a project: Mobile-Web-Sprint-47-Undercover-Brother.
phuedx added a comment.May 12 2015, 10:38 AM

… and the main menu template isn't written to handle multiple links with a single entry.

phuedx moved this task from Needs Analysis to Code Review on the Mobile-Web-Sprint-47-Undercover-Brother board.May 12 2015, 11:06 AM
Jdlrobson claimed this task.May 12 2015, 11:06 AM
Jdlrobson added a project: Gather Sprint Help!.
Jdlrobson reassigned this task from Jdlrobson to phuedx.May 12 2015, 11:08 AM

https://gerrit.wikimedia.org/r/#/c/210301/

phuedx added a comment.May 12 2015, 11:10 AM

Looking at the tests…

Jdlrobson moved this task from In Analysis to Ready for signoff on the Gather Sprint Help! board.May 12 2015, 11:32 AM
Jdlrobson moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.
gerritbot subscribed.May 12 2015, 11:32 AM

Change 210301 merged by jenkins-bot:
Show the logout link

https://gerrit.wikimedia.org/r/210301

phuedx mentioned this in rMEXTae9e873f0715: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….May 12 2015, 11:33 AM
phuedx mentioned this in rEMFReea42cf7ba93: Show the logout link.
phuedx moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-47-Undercover-Brother board.May 12 2015, 12:12 PM
gerritbot added a comment.May 15 2015, 5:37 AM

Change 211078 had a related patch set uploaded (by Phuedx):
Follow on Ibf1cea

https://gerrit.wikimedia.org/r/211078

gerritbot added a project: Patch-For-Review.May 15 2015, 5:37 AM
gerritbot added a comment.May 18 2015, 5:44 PM

Change 211078 merged by jenkins-bot:
Support for cached menu data in HTML

https://gerrit.wikimedia.org/r/211078

Diffusion mentioned this in rMEXTa5b42d955c97: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….May 18 2015, 5:44 PM
Jdlrobson mentioned this in rEMFRca5e44353c2b: Support for cached menu data in HTML.May 18 2015, 5:44 PM
gerritbot added a comment.May 19 2015, 8:05 PM

Change 212050 had a related patch set uploaded (by Kaldari):
Support for cached menu data in HTML

https://gerrit.wikimedia.org/r/212050

gerritbot added a comment.May 19 2015, 8:16 PM

Change 212050 merged by jenkins-bot:
Support for cached menu data in HTML

https://gerrit.wikimedia.org/r/212050

kaldari mentioned this in rEMFRc57b9f51a26f: Support for cached menu data in HTML.May 19 2015, 8:17 PM
phuedx closed this task as Resolved.May 20 2015, 1:34 PM
phuedx removed a project: Patch-For-Review.
phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-47-Undercover-Brother board.
• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Help! board.May 21 2015, 2:21 PM
• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits