Page MenuHomePhabricator

Share A Fact should default to no text selected behavior when only whitespace is highlighted
Closed, ResolvedPublic

Description

  1. Go to an article.
  2. Highlight a space between two words (no printable characters).
  3. Tap the share button in the action bar. Observe that the default system share dialog is used instead of Share A Fact. No text selected behavior is expected.

Details

Related Gerrit Patches:

Event Timeline

Niedzielski raised the priority of this task from to Needs Triage.
Niedzielski updated the task description. (Show Details)
Niedzielski added subscribers: Aklapper, Niedzielski.

Change 217766 had a related patch set uploaded (by Dbrant):
Simplify and fix inconsistencies in share-a-fact handlers.

https://gerrit.wikimedia.org/r/217766

Change 217766 merged by jenkins-bot:
Simplify and fix inconsistencies in share-a-fact handlers.

https://gerrit.wikimedia.org/r/217766

Etonkovidova added a subscriber: Etonkovidova.EditedJun 17 2015, 3:30 PM

Checked with 2.0.103-alpha-2015-06-16 Samsung Tablet Ce0168(Android 4.0.4)- Share fact always displays the default Share fact. Making selection of text - highlighting - does not get reflected on the Share fact card.

Checked with .0.105-alpha-2015-07-08 on Nexus 5 API 22 x86.

Dbrant closed this task as Resolved.Jul 21 2015, 12:00 PM