Share A Fact should default to no text selected behavior when only whitespace is highlighted
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Niedzielski
	May 13 2015, 6:41 PM

Description

Go to an article.
Highlight a space between two words (no printable characters).
Tap the share button in the action bar. Observe that the default system share dialog is used instead of Share A Fact. No text selected behavior is expected.

Details

	Subject	Repo	Branch	Lines +/-
	Simplify and fix inconsistencies in share-a-fact handlers.	apps/android/wikipedia	master	+160 -189

Customize query in gerrit

Related Objects

Mentioned In: T103788: Android Production Release 2.0.105
rAPAW556287280c37: Simplify and fix inconsistencies in share-a-fact handlers.

Event Timeline

• Niedzielski created this task.May 13 2015, 6:41 PM

• Niedzielski raised the priority of this task from to Needs Triage.

• Niedzielski updated the task description. (Show Details)

• Niedzielski added a project: Wikipedia-Android-App-Backlog.

• Niedzielski added subscribers: Aklapper, • Niedzielski.

Change 217766 had a related patch set uploaded (by Dbrant):
Simplify and fix inconsistencies in share-a-fact handlers.

https://gerrit.wikimedia.org/r/217766

gerritbot added a project: Patch-For-Review.Jun 12 2015, 2:59 PM

Dbrant claimed this task.Jun 12 2015, 3:01 PM

Dbrant added a project: Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together.

Dbrant set Security to None.

Dbrant moved this task from To Do to Code Review on the Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together board.

Change 217766 merged by jenkins-bot:
Simplify and fix inconsistencies in share-a-fact handlers.

https://gerrit.wikimedia.org/r/217766

Dbrant mentioned this in rAPAW556287280c37: Simplify and fix inconsistencies in share-a-fact handlers..Jun 12 2015, 6:41 PM

Dbrant moved this task from Code Review to QA Signoff on the Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together board.Jun 12 2015, 7:33 PM

Dbrant moved this task from Needs Triage to Current Sprint on the Wikipedia-Android-App-Backlog board.Jun 15 2015, 9:23 PM

Checked with 2.0.103-alpha-2015-06-16 Samsung Tablet Ce0168(Android 4.0.4)- Share fact always displays the default Share fact. Making selection of text - highlighting - does not get reflected on the Share fact card.

Dbrant edited projects, added Mobile-App-Sprint-60-Android-Lightning-Round; removed Mobile-App-Sprint-59-Android-Getting-the-Band-Back-Together.Jun 24 2015, 5:33 PM

Dbrant moved this task from To Do to QA Signoff on the Mobile-App-Sprint-60-Android-Lightning-Round board.

• bearND mentioned this in T103788: Android Production Release 2.0.105.Jun 25 2015, 6:55 AM

Etonkovidova moved this task from QA Signoff to Design Signoff on the Mobile-App-Sprint-60-Android-Lightning-Round board.Jun 25 2015, 8:26 PM

Etonkovidova moved this task from Design Signoff to QA Signoff on the Mobile-App-Sprint-60-Android-Lightning-Round board.Jun 25 2015, 8:33 PM

Dbrant edited projects, added Mobile-App-Sprint-61-Android-Beach-Boys; removed Mobile-App-Sprint-60-Android-Lightning-Round.Jul 7 2015, 7:25 PM

Dbrant moved this task from To Do to QA Signoff on the Mobile-App-Sprint-61-Android-Beach-Boys board.