Page MenuHomePhabricator
Create Task
Maniphest T99849

Notice on edit via API: JobQueueGroup::__destruct: 1 buffered job(s) never inserted
Closed, ResolvedPublic
Actions

Description

Whenever I try to make an edit via API (for example from the mobile interface) in my local instance, an HTML notice gets inserted into the JSON response, breaking the response parsing:

{"edit":{"result":"Success","pageid":989,"title":"Selenium no languages test page","contentmodel":"wikitext"
,"oldrevid":3214,"newrevid":3215,"newtimestamp":"2015-05-20T22:22:17Z"}}<br />
<b>Notice</b>: JobQueueGroup::__destruct: 1 buffered job(s) never inserted. in <b>/Users/kaldari/Sites
/core/includes/jobqueue/JobQueueGroup.php</b> on line <b>419</b><br />

Details

SubjectRepoBranchLines +/-
Flush lazy jobs in load.php and api.php toomediawiki/corewmf/1.26wmf6+4 -0
Flush lazy jobs in load.php and api.php toomediawiki/coremaster+4 -0
Flush lazy jobs in load.php and api.php toomediawiki/corewmf/1.26wmf7+4 -0
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.May 20 2015, 10:25 PM
kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added projects: MediaWiki-Action-API, MediaWiki-Core-JobQueue.
kaldari subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2015, 10:25 PM
kaldari added a subscriber: Legoktm.May 20 2015, 10:35 PM

@Legoktm Looks like this was introduced by https://gerrit.wikimedia.org/r/#/c/211946/

kaldari added a comment.May 20 2015, 10:45 PM

@Legoktm Nevermind, bad git bisect...

kaldari added a subscriber: aaron.May 20 2015, 10:46 PM

@aaron Looks like this was introduced by https://gerrit.wikimedia.org/r/#/c/211748/

kaldari set Security to None.May 20 2015, 10:48 PM
kaldari removed a subscriber: Legoktm.
aaron added a comment.May 20 2015, 10:54 PM

Looks like load.php and api.php are half-way copy-pasting MW shutdown methods...

A short term fixing is to just flush jobs there too.

Legoktm mentioned this in T99775: Qunit test always fail in Wikidata Jenkins jobs..May 20 2015, 10:56 PM
gerritbot subscribed.May 20 2015, 11:01 PM

Change 212473 had a related patch set uploaded (by Aaron Schulz):
Flush lazy jobs in load.php and api.php too

https://gerrit.wikimedia.org/r/212473

gerritbot added a project: Patch-For-Review.May 20 2015, 11:01 PM
gerritbot added a comment.May 20 2015, 11:22 PM

Change 212473 merged by jenkins-bot:
Flush lazy jobs in load.php and api.php too

https://gerrit.wikimedia.org/r/212473

aaron mentioned this in rMWe58e4b498dcc: Flush lazy jobs in load.php and api.php too.May 20 2015, 11:24 PM
gerritbot added a comment.May 20 2015, 11:38 PM

Change 212477 had a related patch set uploaded (by Aaron Schulz):
Flush lazy jobs in load.php and api.php too

https://gerrit.wikimedia.org/r/212477

gerritbot added a comment.May 21 2015, 12:04 AM

Change 212477 merged by Ori.livneh:
Flush lazy jobs in load.php and api.php too

https://gerrit.wikimedia.org/r/212477

aaron mentioned this in rMW6f44bb8205d9: Flush lazy jobs in load.php and api.php too.May 21 2015, 12:05 AM
gerritbot added a comment.May 21 2015, 12:05 AM

Change 212486 had a related patch set uploaded (by Aaron Schulz):
Flush lazy jobs in load.php and api.php too

https://gerrit.wikimedia.org/r/212486

gerritbot added a comment.May 21 2015, 12:14 AM

Change 212486 merged by jenkins-bot:
Flush lazy jobs in load.php and api.php too

https://gerrit.wikimedia.org/r/212486

aaron mentioned this in rMW8f93a01bfd89: Flush lazy jobs in load.php and api.php too.May 21 2015, 12:14 AM
Anomie subscribed.May 23 2015, 9:31 AM

So is this fixed now, or is there something that needs to be done yet?

Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.May 23 2015, 9:31 AM
Nemo_bis mentioned this in T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.May 23 2015, 1:42 PM
aaron closed this task as Resolved.Jun 3 2015, 9:28 PM
aaron claimed this task.
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL