@dchan and I built live merge, as noted above. I've worked out how to add things to toolbars, with my main difficulty having been that the package I'd put the code in didn't load before the toolbar was constructed. I've learned about InputWidget which simplified my dialog code and I've now got a dialog that changes a message depending on the user's input. Now to simply (!) wire that up to the diff mechanisms. The main issue I'm anticipating here is working out the linkage between the MW code and the VE code: I think I need to pass the various documents as arguments.

Finding the current section headings is also done in ve.ui.MWTocWidget.js, which might be a useful place to start

This week I've worked out to highlight text inline and spent some time learning how dialogs are built in OOUI

@dchan and I investigated the current codebase. We experimented with ve.dm.Document#findText and found that the performance was perfectly acceptable on a dev laptop (big caveat!) with a 1000-word regex and one of the largest articles on wikipedia and another large article. We still need to try this on a more constrained device.

The current status is I've worked out how to load various revisions into the codebase and how to do a diff between them. I'm currently pursuing two lines of enquiry: working out how to get a VisualDiff object (or something upstream from that) into a ve.dm.Change format, and building a dialog that allows diffs against various targets, such as between the user's changes and the base document, between the base document and the current version on wiki, and so on. The objective at this point remains getting enough of this corner of this codebase into my head as to be useful, do not expect this ticket to be closed quickly.

I have confirmed that it was doing this because I introduced a bug and then didn't catch it before submitting the change for QA. Sorry about that.

Good catch – definitely not intended behaviour to prevent the dialog from closing in edit mode if the user has not made a change. I'll investigate why it's doing this.

It's just a beta issue – apparently nobody's actively maintaining it. I fired up a patchdemo and was able to upload an image just fine.

Whoops, I didn't mean to give it such an alarming title. I should proofread better, sorry about that.

I've not been able to reproduce on the main branch so it might be environmental?

Thanks for double checking… I was hoping it would just be transient.

I'm having trouble reproing so I'm not sure how to proceed. I'll have another go in a couple days.

Oddly, hitting "F8" or closing the source code editor doesn't cause this bug whereas clicking "resume script execution" does. I'm now not sure it's not a browser bug instead.

I've also confirmed this. I just worked on another bug in the media viewer and found (by forgetting to bring my mediawiki instance back to the present!) that this is a relatively recent regression.

I have a patch ready for this specific plugin. However, it made sense to move this change over to the VE codebase such that any plugin that creates a dialog can benefit from the check for unsaved changes. I'll be submitting that shortly for feedback.