Page MenuHomePhabricator
Create Task
Maniphest T206016

Create a service for session storage
Closed, ResolvedPublic
Actions

Description

Implement a multi-master (multi-DC) session storage service.

See T206010: RfC: Session storage service interface and T206015: Plan/design a session storage service, for interface (RfC) and software design respectively.

Details

SubjectRepoBranchLines +/-
Remove integration test setup and teardownmediawiki/services/kaskmaster+0 -11
Relocate `defer` to immediately after DB initmediawiki/services/kaskmaster+3 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedaaronT88445 MediaWiki active/active datacenter investigation and work (tracking)
 ResolvedEevansT206016 Create a service for session storage
 ResolvedEevansT206015 Plan/design a session storage service
 ResolvedEevansT206010 RfC: Session storage service interface
 ResolvedEevansT209098 Document Kask
 Resolved• ClarakosiT209099 Establish baseline performance of Python/WSGI frameworks
 DeclinedEevansT209102 Add JSON encoding/decoding to RESTBagOStuff
 ResolvedEevansT209106 Setup session storage service testing/continuous integration
 ResolvedEevansT209108 Monitoring and data collection for session storage service
 ResolvedEevansT222227 Kask support for operations/software/service-checker
 ResolvedEevansT209109 Security model for session storage service
 ResolvedEevansT209110 Logging for the session storage service
 ResolvedEvanProdromouT211721 Establish an SLA for session storage
 ResolvedBPirkleT215533 Enable use of session storage service in MediaWiki
 ResolvedEvanProdromouT221983 QA Plan for RESTBagOStuff
 ResolvedBPirkleT227096 Test migration process for session storage
 ResolvedEvanProdromouT221986 Security Review of RESTBagOStuff
 ResolvedEvanProdromouT221987 Performance testing of RESTBagOStuff
 ResolvedBPirkleT222099 Staging release of RESTBagOStuff using Kask
 ResolvedBPirkleT227097 Make sure that we're taking CentralAuth into consideration for staging release
 ResolvedBPirkleT227696 OAuth extension uses session object store directly
 ResolvedBPirkleT222742 MigrationBagOStuff
 ResolvedBPirkleT224993 Example configuration clauses for using RESTBagOStuff with Kask
 ResolvedEevansT215883 Session storage Cassandra cluster configuration
 ResolvedfgiunchediT219523 Session storage Cassandra metrics (Prometheus) not being collected
 ResolvedDzahnT219560 Credentials needed for session storage Cassandra cluster
 ResolvedEevansT217650 Deployment strategy for the session storage application.
 ResolvedsbassettT219831 Security Review For Kask
 ResolvedEevansT221292 Establish performance of the session storage service
 ResolvedEevansT229697 Investigate Kask request latency
 ResolvedDzahnT230178 Install wrk, siege and lua-cjson packages on deploy1001
 ResolvedEevansT230515 Grafana dashboards for sessionstore, k8s staging, are not working
 ResolvedEvanProdromouT222907 Determine if per-request TTLs are needed
 ResolvedEvanProdromouT222908 Determine if set-if-not-exists method is necessary for session storage
 ResolvedEevansT222990 Audit session storage to determine max age of un-GC'd sessions
 ResolvedEevansT224620 Convert Cassandra contact to a list
 ResolvedEevansT224995 Document that session TTL mismatch between Kask and MediaWiki (or other applications) will be silently ignored
 ResolvedBPirkleT226666 RESTBagOStuff client error handling
 ResolvedEevansT226988 Add/report build meta data
 ResolvedEevansT226989 Document the session storage service
 ResolvedakosiarisT227514 k8s liveness check(?) generating session storage log noise
 ResolvedEevansT243106 Phased rollout of sessionstore to production fleet
 Invalid• PcheloloT244888 Investigate ways to decrease MW->sessionstore traffic
 DeclinedNoneT254422 Move CentralAuth sessions from redis backend to kask

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2018, 7:24 PM
Eevans triaged this task as Medium priority.Oct 2 2018, 7:34 PM
Eevans moved this task from Backlog to In-Progress on the User-Eevans board.
Eevans added a subscriber: CCicalese_WMF.
Eevans renamed this task from Implement multi-DC session storage service to Implement session storage service.Oct 2 2018, 7:40 PM
Eevans moved this task from Inbox to Session Management Service (CDP2) on the Platform Engineering board.
Eevans edited projects, added Platform Engineering (Session Management Service (CDP2)); removed Platform Engineering.
CCicalese_WMF added a subtask: T206015: Plan/design a session storage service.Oct 16 2018, 3:27 PM
CCicalese_WMF added a project: Platform Team Legacy (Next).
dr0ptp4kt subscribed.Oct 30 2018, 5:42 PM
Eevans moved this task from In-Progress to Next on the User-Eevans board.Nov 6 2018, 9:56 PM
Eevans renamed this task from Implement session storage service to Session storage service: Implementation.Nov 8 2018, 7:52 PM
Eevans updated the task description. (Show Details)
Eevans edited subscribers, added: • Clarakosi; removed: dr0ptp4kt.
Eevans added a project: User-Clarakosi.Nov 8 2018, 8:23 PM
Eevans closed subtask T209102: Add JSON encoding/decoding to RESTBagOStuff as Declined.Nov 30 2018, 2:48 PM
Eevans renamed this task from Session storage service: Implementation to Implement a session storage service.Dec 11 2018, 8:16 PM
Eevans updated the task description. (Show Details)
Eevans renamed this task from Implement a session storage service to Create a service for session storage.Dec 13 2018, 5:19 PM
Eevans added a subtask: T212129: Move MainStash out of Redis to a simpler multi-dc aware solution.Jan 10 2019, 3:49 PM
gerritbot subscribed.Jan 15 2019, 2:10 PM

Change 484431 had a related patch set uploaded (by Eevans; owner: Eevans):
[mediawiki/services/kask@master] Relocate defer to immediately after DB init

https://gerrit.wikimedia.org/r/484431

gerritbot added a project: Patch-For-Review.Jan 15 2019, 2:10 PM
Eevans mentioned this in rMSKSef1d5bf137be: Relocate `defer` to immediately after DB init.Jan 15 2019, 2:14 PM
gerritbot added a comment.Jan 15 2019, 5:48 PM

Change 484431 merged by Eevans:
[mediawiki/services/kask@master] Relocate defer to immediately after DB init

https://gerrit.wikimedia.org/r/484431

gerritbot added a comment.Jan 15 2019, 11:55 PM

Change 484598 had a related patch set uploaded (by Clarakosi; owner: Clarakosi):
[mediawiki/services/kask@master] Modified integration tests

https://gerrit.wikimedia.org/r/484598

• Clarakosi mentioned this in rMSKS19389fc883fd: Modified integration tests.Jan 15 2019, 11:57 PM
• Clarakosi mentioned this in rMSKS51cb916c2594: Removed binary start/end from integration tests.Jan 16 2019, 4:09 PM
Eevans mentioned this in rMSKS3c97d706f1ad: Remove integration test setup and teardown.Jan 16 2019, 4:42 PM
gerritbot added a comment.Jan 16 2019, 4:44 PM

Change 484598 merged by Eevans:
[mediawiki/services/kask@master] Remove integration test setup and teardown

https://gerrit.wikimedia.org/r/484598

• Clarakosi moved this task from Backlog to In-Progress on the User-Clarakosi board.Feb 8 2019, 5:44 PM
jijiki added a subtask: T215883: Session storage Cassandra cluster configuration.Feb 12 2019, 10:21 AM
Eevans moved this task from Next to In-Progress on the User-Eevans board.Feb 13 2019, 3:25 PM
• mobrovac edited projects, added Platform Engineering (Multi-DC (TEC1)); removed Platform Engineering (Session Management Service (CDP2)).Feb 27 2019, 11:33 PM
• mobrovac added a parent task: T88445: MediaWiki active/active datacenter investigation and work (tracking).
• mobrovac mentioned this in T134811: Consider REST with SSL (HyperSwitch/Cassandra) for session storage.Feb 27 2019, 11:35 PM
jijiki mentioned this in rMSKSb6cd52012a43: Remove integration test setup and teardown.Mar 18 2019, 4:35 PM
jijiki mentioned this in rMSKS90f39b754a9f: Relocate `defer` to immediately after DB init.
EvanProdromou mentioned this in T219524: respect WRITE_SYNC (e.g. EACH_QUORUM) in RESTBagOStuff::set().Mar 29 2019, 6:49 PM
Eevans closed subtask T206015: Plan/design a session storage service as Resolved.Apr 1 2019, 2:25 PM
Eevans added a subtask: T219831: Security Review For Kask.Apr 1 2019, 7:48 PM
Eevans closed subtask T209099: Establish baseline performance of Python/WSGI frameworks as Resolved.Apr 17 2019, 8:58 PM
Eevans closed subtask T215883: Session storage Cassandra cluster configuration as Resolved.Apr 25 2019, 3:48 PM
EvanProdromou removed a subtask: T212129: Move MainStash out of Redis to a simpler multi-dc aware solution.May 9 2019, 5:34 PM
EvanProdromou closed subtask T222908: Determine if set-if-not-exists method is necessary for session storage as Resolved.May 21 2019, 2:53 PM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:50 PM
Eevans closed subtask T224620: Convert Cassandra contact to a list as Resolved.May 30 2019, 5:09 PM
EvanProdromou closed subtask T222907: Determine if per-request TTLs are needed as Resolved.Jun 4 2019, 2:56 PM
Eevans closed subtask T209108: Monitoring and data collection for session storage service as Resolved.Jun 11 2019, 6:19 PM
Eevans closed subtask T217650: Deployment strategy for the session storage application. as Resolved.Jun 11 2019, 7:12 PM
Eevans closed subtask T219831: Security Review For Kask as Resolved.Jun 12 2019, 2:24 PM
Eevans closed subtask T226666: RESTBagOStuff client error handling as Resolved.Jun 27 2019, 2:52 PM
Eevans removed a subtask: T220246: Management of Cassandra schema and keyspace/table configuration.Jun 28 2019, 6:01 PM
Eevans closed subtask T226988: Add/report build meta data as Resolved.Jul 3 2019, 9:47 PM
WDoranWMF added a subtask: T227514: k8s liveness check(?) generating session storage log noise.Jul 18 2019, 8:33 PM
Eevans closed subtask T226989: Document the session storage service as Resolved.Jul 18 2019, 11:32 PM
WDoranWMF removed a project: Platform Team Legacy (Next).Jul 26 2019, 5:46 PM
WDoranWMF moved this task from Multi-DC (TEC1) to mop on the Platform Engineering board.Jul 26 2019, 6:47 PM
WDoranWMF edited projects, added Platform Team Initiatives (Multi-DC (TEC1)); removed Platform Engineering (Multi-DC (TEC1)).
EvanProdromou closed subtask T211721: Establish an SLA for session storage as Resolved.Jul 30 2019, 4:43 PM
BPirkle mentioned this in T233537: Document and communicate potentially breaking session storage serialization change.Sep 22 2019, 7:56 PM
BPirkle mentioned this in T233963: Add serialization options to RESTBagOStuff.Sep 26 2019, 4:03 PM
Eevans closed subtask T209110: Logging for the session storage service as Resolved.Oct 8 2019, 2:47 PM
akosiaris closed subtask T227514: k8s liveness check(?) generating session storage log noise as Resolved.Nov 13 2019, 11:11 PM
• Pchelolo closed subtask T244888: Investigate ways to decrease MW->sessionstore traffic as Invalid.Feb 11 2020, 7:35 PM
• eprodromou closed subtask T224995: Document that session TTL mismatch between Kask and MediaWiki (or other applications) will be silently ignored as Resolved.Mar 11 2020, 6:39 PM
• eprodromou added a project: Platform Team Workboards (Initiatives).Mar 17 2020, 3:26 PM
• eprodromou moved this task from Later to Now on the Platform Team Workboards (Initiatives) board.
• Pchelolo moved this task from Now to Paused on the Platform Team Workboards (Initiatives) board.Mar 17 2020, 5:26 PM
CCicalese_WMF edited projects, added Platform Team Initiatives (Session Management Service (CDP2)); removed Platform Team Initiatives (Multi-DC (TEC1)).Mar 19 2020, 1:44 AM
CCicalese_WMF closed subtask T209098: Document Kask as Resolved.Apr 28 2020, 8:49 PM
Naike closed subtask T221292: Establish performance of the session storage service as Resolved.May 22 2020, 6:49 AM
Naike changed the task status from Open to Stalled.May 29 2020, 9:20 AM
Krinkle mentioned this in T212129: Move MainStash out of Redis to a simpler multi-dc aware solution.Jun 2 2020, 5:07 PM
Krinkle mentioned this in T243520: Decommission the "session redis" cluster.Jun 2 2020, 5:26 PM
• eprodromou closed subtask T215533: Enable use of session storage service in MediaWiki as Resolved.Jun 3 2020, 7:18 PM
• Pchelolo closed subtask T243106: Phased rollout of sessionstore to production fleet as Resolved.Jun 3 2020, 7:19 PM
• Pchelolo subscribed.Jun 3 2020, 7:55 PM

We have completely deployed kask-session for non-central-auth sessions across all wikis. However, this only cuts Redis request rate by half, so we need to toll out to CentralAuth.

• Pchelolo closed subtask T209109: Security model for session storage service as Resolved.Jun 4 2020, 4:30 PM
thcipriani closed subtask T209106: Setup session storage service testing/continuous integration as Resolved.Jun 25 2020, 7:35 PM
BPirkle closed subtask T254422: Move CentralAuth sessions from redis backend to kask as Declined.Nov 5 2020, 10:49 PM
Reedy mentioned this in T269680: MediaWiki logging indexing conflict on 'session' for 'session-ip' channel.Dec 9 2020, 3:02 PM
Krinkle mentioned this in T270225: Finish session storage to actually meet multi-DC requirements.Dec 17 2020, 2:04 AM
RhinosF1 subscribed.Jan 25 2021, 8:34 PM
Krinkle mentioned this in T135113: Rationalize our jobqueues redis topology.Apr 25 2021, 10:56 PM
Eevans closed subtask T222990: Audit session storage to determine max age of un-GC'd sessions as Resolved.Jun 7 2021, 9:09 PM
Eevans removed a project: User-Eevans.Jun 9 2021, 4:40 PM

This is done; I move to close this issue.

Aklapper added a comment.Jun 9 2021, 8:13 PM

@Eevans If this task is done can its task status be changed to resolved?

Eevans added a subscriber: WDoranWMF.Jun 10 2021, 1:51 PM
In T206016#7147120, @Aklapper wrote:

@Eevans If this task is done can its task status be changed to resolved?

I don't know, it's on the Platform Team Workboards (Initiatives) workboard, and I think there is some...process, for closing it out. @WDoranWMF ?

greg closed this task as Resolved.Oct 20 2021, 12:06 AM
greg subscribed.

Boldly resolving given that workboard is archived and Eevans said it is done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL